Date: Fri, 21 Feb 2014 15:44:54 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r345514 - head/Mk/Uses Message-ID: <5307C8D6.7090309@FreeBSD.org> In-Reply-To: <20140221193004.GM1699@ithaqua.etoilebsd.net> References: <201402211647.s1LGlTuw053335@svn.freebsd.org> <20140221194949.29595e47@kalimero.tijl.coosemans.org> <20140221193004.GM1699@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --apW5EkfmXLgajtFFbNs0ji3C0vGEAI2Dt Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2/21/2014 1:30 PM, Baptiste Daroussin wrote: > On Fri, Feb 21, 2014 at 07:49:49PM +0100, Tijl Coosemans wrote: >> On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote: >>> Author: bapt >>> Date: Fri Feb 21 16:47:29 2014 >>> New Revision: 345514 >>> URL: http://svnweb.freebsd.org/changeset/ports/345514 >>> QAT: https://qat.redports.org/buildarchive/r345514/ >>> >>> Log: >>> libtool 1.4.2a was defining the shared extension as shrext_cmds, re= name it shared_ext >>> like in newer libtool so the rest of USES=3Diconv magic just works >>> >>> Modified: >>> head/Mk/Uses/libtool.mk >>> >>> Modified: head/Mk/Uses/libtool.mk >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/Mk/Uses/libtool.mk Fri Feb 21 16:04:38 2014 (r345513) >>> +++ head/Mk/Uses/libtool.mk Fri Feb 21 16:47:29 2014 (r345514) >>> @@ -22,7 +22,8 @@ patch-libtool: >>> -e '/link_all_deplibs[0-9A-Z_]*=3D/s/=3Dunknown/=3Dno/' \ >>> -e '/objformat=3D/s/echo aout/echo elf/' \ >>> -e "/freebsd-elf\\*)/,/;;/ { \ >>> - /deplibs_check_method=3D/s/=3D.*/=3Dpass_all/; }" >>> + /deplibs_check_method=3D/s/=3D.*/=3Dpass_all/; }" \ >>> + -e "s/shrext_cmds/shared_ext/g" >>> =20 >>> .if ! ${libtool_ARGS:Moldver} >>> @${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \) \ >> >> Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use= >> only one name. shrext_cmds is defined by configure (normally just .so= >> for us) or by libtool when invoked with -shrext some_extension. Then >> later libtool defines shared_ext using 'eval shared_ext=3D\"$shrext_cm= ds\"'. >> >> What port does this fix? >=20 > devel/libghthash is the port broken if you end up with a better fix, pl= ease just > commit. >=20 > Thank you > Bapt >=20 This was causing libraries to build without .so, I have reverted for now.= Note: > =3D=3D=3D> Checking if sysutils/hal already installed > =3D=3D=3D> Registering installation for hal-0.5.14_23 > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al-storage.a): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al-storage.la): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al-storage.so): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al-storage.so.1): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al-storage.so.1.0.0): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al.so): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al.so.1): No such file or directory > pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libh= al.so.1.0.0): No such file or directory > *** Error code 74 (continuing) > `/usr/ports/sysutils/hal/work/.install_done.hal._usr_local' not remade = because of errors. and > libtool: install: /usr/bin/install -c -o root -g wheel .libs/liblogging= -stdlog.0.0.0 /wrkdirs/usr/ports/devel/liblogging/work/stage/usr/local/li= b/liblogging-stdlog.0.0.0 --=20 Regards, Bryan Drewery --apW5EkfmXLgajtFFbNs0ji3C0vGEAI2Dt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTB8jWAAoJEDXXcbtuRpfPZrgIAJb4v5mSyWC/f8TbdrS7UWPv BYTA+71NH44qTvtVglN+99dkRIcf9RikpdRHpRfJw056CxbLMPW1PGXiUKgsmXFA ++drR+cvp/WwD7MkYH/i0Mug3OCJXK2xGbd1tpoMBs4yzToUbBL64DZi5VgCk9Aa dnuEid2MiglzpG3wihhISzcssNy8sSgY+RcLel1k8tnBsU0p4rZYhVXgInmtqVwj b7ieIATwP8nLa1j0Oc4f9C1uDq+sKD3EznWnAs5wwKJPSI/fCdMGpZtY8LGmiVSN GmJ1VImP+c/BNZS84sN0aXbPEYvH0wYZHH+1grvLcMxUBB+0JGH6/mbTTgBKtMU= =Zeoh -----END PGP SIGNATURE----- --apW5EkfmXLgajtFFbNs0ji3C0vGEAI2Dt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5307C8D6.7090309>