Date: Mon, 8 Aug 2011 21:40:12 GMT From: Fabian Keil <fk@fabiankeil.de> To: freebsd-usb@FreeBSD.org Subject: Re: usb/159611: [PATCH] USB stick extrememory Snippy needs quirks Message-ID: <201108082140.p78LeCgB067665@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/159611; it has been noted by GNATS.
From: Fabian Keil <fk@fabiankeil.de>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: usb/159611: [PATCH] USB stick extrememory Snippy needs quirks
Date: Mon, 8 Aug 2011 23:24:00 +0200
--Sig_/2wHg79VOsJ_9hGDlJbNnKcd
Content-Type: multipart/mixed; boundary="MP_/Nc2ncPb7wZ+fq1qVR/9.evn"
--MP_/Nc2ncPb7wZ+fq1qVR/9.evn
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Looks like the patch didn't make it the first time.
Fabian
--MP_/Nc2ncPb7wZ+fq1qVR/9.evn
Content-Type: text/x-patch
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename=Add-quirks-for-extrememory-s-Snippy-and-similar-Supe.patch
=46rom 7c1ac6411d3b92bf56a5bf5ebdc14c4af0683e80 Mon Sep 17 00:00:00 2001
From: Fabian Keil <fk@fabiankeil.de>
Date: Sat, 6 Aug 2011 13:00:45 +0200
Subject: [PATCH] Add quirks for extrememory's Snippy and similar
Supertop-based devices
Without UQ_MSC_NO_TEST_UNIT_READY, the stick can't be
used until 2 to 3 resets ("kernel: Opened disk da0 -> 6").
Without UQ_MSC_NO_SYNC_CACHE, using the stick as part
of ZFS pool causes lots of log messages like:
kernel: (da0:umass-sim0:0:0:0): SCSI status error
kernel: (da0:umass-sim0:0:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 =
0 0 0
kernel: (da0:umass-sim0:0:0:0): CAM status: SCSI Status Error
kernel: (da0:umass-sim0:0:0:0): SCSI status: Check Condition
kernel: (da0:umass-sim0:0:0:0): SCSI sense: ILLEGAL REQUEST asc:20,0 (Inval=
id command operation code)
kernel: (da0:umass-sim0:0:0:0): Error 22, Unretryable error
---
sys/dev/usb/quirk/usb_quirk.c | 2 ++
sys/dev/usb/usbdevs | 1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c
index 12083ac..acb4e39 100644
--- a/sys/dev/usb/quirk/usb_quirk.c
+++ b/sys/dev/usb/quirk/usb_quirk.c
@@ -399,6 +399,8 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS=
_MAX] =3D {
UQ_MSC_FORCE_PROTO_SCSI),
USB_QUIRK(SUPERTOP, IDE, 0x0000, 0xffff, UQ_MSC_IGNORE_RESIDUE,
UQ_MSC_NO_SYNC_CACHE),
+ USB_QUIRK(SUPERTOP, FLASHDRIVE, 0x0000, 0xffff, UQ_MSC_NO_TEST_UNIT_READY,
+ UQ_MSC_NO_SYNC_CACHE),
USB_QUIRK(TAUGA, CAMERAMATE, 0x0000, 0xffff, UQ_MSC_FORCE_PROTO_SCSI),
USB_QUIRK(TEAC, FD05PUB, 0x0000, 0xffff, UQ_MSC_FORCE_WIRE_CBI,
UQ_MSC_FORCE_PROTO_UFI),
diff --git a/sys/dev/usb/usbdevs b/sys/dev/usb/usbdevs
index 101d630..f59fd43 100644
--- a/sys/dev/usb/usbdevs
+++ b/sys/dev/usb/usbdevs
@@ -3211,6 +3211,7 @@ product SUN KBD_HUB 0x100e Kbd Hub
=20
/* Super Top products */
product SUPERTOP IDE 0x6600 USB-IDE
+product SUPERTOP FLASHDRIVE 0x121c extrememory Snippy
=20
/* Syntech products */
product SYNTECH CPT8001C 0x0001 CPT-8001C Barcode scanner
--=20
1.7.6
--MP_/Nc2ncPb7wZ+fq1qVR/9.evn--
--Sig_/2wHg79VOsJ_9hGDlJbNnKcd
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
iEYEARECAAYFAk5AU/IACgkQSMVSH78upWP6gQCfR8JcY+I2BViWDvHveRYEKr4B
JJQAn0gwhJeqiqG1olw8ahVnzyKAbaJ3
=u+NK
-----END PGP SIGNATURE-----
--Sig_/2wHg79VOsJ_9hGDlJbNnKcd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108082140.p78LeCgB067665>