From owner-freebsd-hackers Fri Feb 21 10:53:26 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1612A37B401 for ; Fri, 21 Feb 2003 10:53:24 -0800 (PST) Received: from heron.mail.pas.earthlink.net (heron.mail.pas.earthlink.net [207.217.120.189]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CC4143F85 for ; Fri, 21 Feb 2003 10:53:23 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from dialup-209.245.134.181.dial1.sanjose1.level3.net ([209.245.134.181] helo=mindspring.com) by heron.mail.pas.earthlink.net with asmtp (SSLv3:RC4-MD5:128) (Exim 3.33 #1) id 18mIIT-0007PZ-00; Fri, 21 Feb 2003 10:53:22 -0800 Message-ID: <3E5673E5.7AAEBEAA@mindspring.com> Date: Fri, 21 Feb 2003 10:45:57 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: omestre Cc: freebsd-hackers@freebsd.org Subject: Re: bootp_subr.c patch References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a4618b3c353e223a8aefc92d11e3da1a0a2601a10902912494350badd9bab72f9c350badd9bab72f9c Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG omestre wrote: > + * Copyright (c) 2002 Marcelo Leal This is generally frowned upon, but not strictly prohibited, if the code changes are significant. > - * This product includes software developed by the University of > - * California, Lawrence Berkeley Laboratory and its contributors. > + * This product includes software developed by the University of > + * California, Lawrence Berkeley Laboratory and its contributors. This is just plain gratuitous. > - * $NetBSD: krpc_subr.c,v 1.10 1995/08/08 20:43:43 gwr Exp $ > + * $NetBSD: krpc_subr.c,v 1.10 1995/08/08 20:43:43 gwr Exp $ Uh... FreeBSD. > @@ -56,14 +57,11 @@ > #include > #include > #include > - > #include > #include > - [ ... ] Gratuitous. [ ... rest of patch: mostly inoffensive ... ] > + /* The start... */ > + printf("---------------------------------FILE HANDLE PATCH\n", "%s"); > + printf("\033\[01\;34mCia de Processamento de Dados do Rio Grande do > Sul\033\[0m\n", "%s"); > + printf("--------------------------------------------------\n", "%s"); > + setup_nfsdiskless(); > + printf("--------------------------------------------------\n", "%s"); ...except this part. 1) Adding a printed copyright is really unacceptable. 2) Putting out a huge visual block is annoying; not only does the user not care to know this, the static strings are useless repetitive and long, in an area where data space is at a premium. 3) Use of ANSI escape sequences assumes a console that can interpret them; not all consoles will be able to do so, so this is prohibited, period. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message