From owner-svn-src-stable-10@freebsd.org  Tue Aug 15 13:10:14 2017
Return-Path: <owner-svn-src-stable-10@freebsd.org>
Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38B9EDD318C;
 Tue, 15 Aug 2017 13:10:14 +0000 (UTC)
 (envelope-from lwhsu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1A1546F1F4;
 Tue, 15 Aug 2017 13:10:14 +0000 (UTC)
 (envelope-from lwhsu@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1129)
 id 6B754D67A; Tue, 15 Aug 2017 13:10:13 +0000 (UTC)
Date: Tue, 15 Aug 2017 13:10:13 +0000
From: Li-Wen Hsu <lwhsu@FreeBSD.org>
To: Kirk McKusick <mckusick@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject: Re: svn commit: r322513 - stable/10/sys/geom/journal
Message-ID: <20170815131013.GA29681@freefall.freebsd.org>
References: <201708141912.v7EJCqsc017835@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201708141912.v7EJCqsc017835@repo.freebsd.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-BeenThere: svn-src-stable-10@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for only the 10-stable src tree
 <svn-src-stable-10.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-10/>
List-Post: <mailto:svn-src-stable-10@freebsd.org>
List-Help: <mailto:svn-src-stable-10-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Aug 2017 13:10:14 -0000

On Mon, Aug 14, 2017 at 19:12:52 +0000, Kirk McKusick wrote:
> Author: mckusick
> Date: Mon Aug 14 19:12:51 2017
> New Revision: 322513
> URL: https://svnweb.freebsd.org/changeset/base/322513
> 
> Log:
>   MFC of 322178:
>   
>   Bug 198500 reports bad sysctl values for gjournal cache limit.
>   
>   PR: 198500
>   Submitted by: Dr. Andreas Longwitz <longwitz@incore.de>
>   Reported by: Eugene Grosbein
>   Discussed with: kib
>   Approved by: re (marius)
> 
> Modified:
>   stable/10/sys/geom/journal/g_journal.c
> Directory Properties:
>   stable/10/   (props changed)

This change seems breaking build:

/usr/src/sys/modules/geom/geom_journal/../../../geom/journal/g_journal.c:136:1: error: incompatible pointer types initializing 'int *' with an expression of type 'u_long *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
TUNABLE_INT("kern.geom.journal.cache.limit", &g_journal_cache_limit);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@/sys/kernel.h:287:3: note: expanded from macro 'TUNABLE_INT'
                (var),                                          \
                ^~~~~
/usr/src/sys/modules/geom/geom_journal/../../../geom/journal/g_journal.c:178:14: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
        if (cswitch < 0 || cswitch > 100)
            ~~~~~~~ ^ ~

Could you help check this one?
https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-build/1157/console

Thanks,
Li-Wen

-- 
Li-Wen Hsu <lwhsu@FreeBSD.org>
https://lwhsu.org