From owner-freebsd-current Sun Apr 2 10: 3: 3 2000 Delivered-To: freebsd-current@freebsd.org Received: from peedub.muc.de (peedub.muc.de [193.149.49.109]) by hub.freebsd.org (Postfix) with ESMTP id E42A137BE30 for ; Sun, 2 Apr 2000 10:02:50 -0700 (PDT) (envelope-from garyj@peedub.muc.de) Received: from peedub.muc.de (localhost [127.0.0.1]) by peedub.muc.de (8.9.3/8.6.9) with ESMTP id TAA01074; Sun, 2 Apr 2000 19:00:17 +0200 (CEST) Message-Id: <200004021700.TAA01074@peedub.muc.de> X-Mailer: exmh version 2.1.0 09/18/1999 To: Bruce Evans Cc: freebsd-current@FreeBSD.ORG Subject: Re: MLEN and crashes Reply-To: Gary Jennejohn In-reply-to: Your message of "Sun, 02 Apr 2000 13:57:24 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 02 Apr 2000 19:00:17 +0200 From: Gary Jennejohn Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans writes: >On Sun, 2 Apr 2000, Gary Jennejohn wrote: >> Moving the struct spppreq into global address space solves the problem, >> but that makes the kernel BSS somewhat larger. Redefining MAX_HDR to be >> 128 also fixes the problem, even with the struct spppreq on the stack. > >Big structs need to be malloced. > Yes, but how does one know that a struct is too big ? Before the increase in MLEN strucct sppp was not too big. >I think removing the unused bloat in `struct cstate' is the correct fix >for this particular allocation. > I think we should nuke csu_hdr since it's not used anywhere. Is that what you really mean ? --- Gary Jennejohn / garyj@muc.de garyj@fkr.cpqcorp.net gj@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message