From owner-cvs-src@FreeBSD.ORG Wed Oct 13 02:07:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3DE716A4D2; Wed, 13 Oct 2004 02:07:08 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8AFB43D55; Wed, 13 Oct 2004 02:07:07 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id BC82265213; Wed, 13 Oct 2004 03:07:05 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 15268-02; Wed, 13 Oct 2004 03:07:05 +0100 (BST) Received: from empiric.dek.spc.org (dhcp126.icir.org [192.150.187.126]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id C43B365211; Wed, 13 Oct 2004 03:07:04 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 29F186465; Tue, 12 Oct 2004 19:06:59 -0700 (PDT) Date: Tue, 12 Oct 2004 19:06:58 -0700 From: Bruce M Simpson To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041013020658.GA4190@empiric.icir.org> Mail-Followup-To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200410120858.i9C8wvJx086204@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <200410120858.i9C8wvJx086204@repoman.freebsd.org> Subject: Re: cvs commit: src/sys/dev/usb umass.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2004 02:07:09 -0000 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 12, 2004 at 08:58:57AM +0000, Bruce M Simpson wrote: > Log: > Pass through the commands necessary to format USB floppy devices, > from within umass_ufi_transform(). This includes the 12-byte commands > FORMAT_UNIT, WRITE_AND_VERIFY, VERIFY, and READ_FORMAT_CAPACITIES > (sorted in numerical order). Postscript. FORMAT_UNIT will be accepted by a UFI or SFF8070i device using camcontrol passthrough. However, UFI devices will *not* accept the 6-byte version of this command. The command will fit, however; there isn't the risk of a buffer overflow or panic that I can see. I have some additional pieces which will need to be committed in order that umass(4) can perform some sanity checking of what it's passing to the device. These are currently part of ufdformat(1), under construction. Regards, BMS --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: '' iD8DBQFBbI3CueUpAYYNtTsRAshrAJ4sBeaoP9AjAt6hq17YCrgJhoIZqACfTOVF HQHMZ03TUa+CkSHHTmdgOyc= =vLaU -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--