From owner-freebsd-gnome@FreeBSD.ORG Tue Feb 10 22:22:30 2004 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3770516A4CE for ; Tue, 10 Feb 2004 22:22:30 -0800 (PST) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8F5143D1F for ; Tue, 10 Feb 2004 22:22:29 -0800 (PST) (envelope-from marcus@FreeBSD.org) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) i1B6INsm084970; Wed, 11 Feb 2004 01:18:23 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Jeremy Messenger In-Reply-To: References: <1076231925.915.8.camel@shumai.marcuscom.com> <1076314663.766.16.camel@localhost> <1076352014.830.61.camel@gyros> <1076399479.1054.3.camel@localhost> <1076442051.733.87.camel@gyros> <1076443069.733.89.camel@gyros><1076455070.819.2.camel@gyros> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Odn74JrXLbQ6DGaOLRGK" Organization: FreeBSD, Inc. Message-Id: <1076480544.45489.9.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 11 Feb 2004 01:22:24 -0500 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on creme-brulee.marcuscom.com cc: "Vladimir B. Grebenschikov" cc: gnome Subject: Re: Looking for GNOME users with KDE X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2004 06:22:30 -0000 --=-Odn74JrXLbQ6DGaOLRGK Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2004-02-10 at 22:52, Jeremy Messenger wrote: > On Tue, 10 Feb 2004 18:18:53 -0500, Joe Marcus Clarke =20 > wrote: >=20 > > Now this is what I'm talking about! Awesome. Let me know when you hav= e > > something you like. Thanks a lot for looking at this. >=20 > Here are two attaches of kde-menus.png and gnomevfs2.diff; I think it's=20 > done. Only one very small issue is that there are a lot of KDE icons=20 > (*.desktop) don't have the 'Categories'. The menu read 'Categories' line=20 > in the *.desktop files, so it's why there has three icons (see=20 > kde-menus.png for yellow square) that are out of order. It will be nice i= f=20 > it's possible to put the in the KDE's and any general= =20 > icon can be in the KDE menu rather than outside. The screenshot didn't make it through. However, this work looks good.=20 One thing I would say is that you can consolidate the post-extract and post-patch into one: .if !defined(WITHOUT_KDE_MENUS) @${SED} -e 's|/usr/local|${LOCALBASE}|g' \ < ${FILESDIR}/KDE.directory > \ ${WRKSRC}/KDE.directory .endif Also, why can't you put the MergeDir under the KDE menu to being with?=20 That sounds perfectly reasonable to me. >=20 > At least, it looks much cleaner than before. :-) >=20 > P.S. Can one of committer take a look at ports/62489? Committed. Joe >=20 > Cheers, > Mezz >=20 > > Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-Odn74JrXLbQ6DGaOLRGK Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAKcofb2iPiv4Uz4cRAtThAJ9KMF5FyvyWoAd6LsMFdMsdodMjFACfT5vX VZPuao9Ywy92T+4dtxU/b9c= =lHbq -----END PGP SIGNATURE----- --=-Odn74JrXLbQ6DGaOLRGK--