From nobody Fri Feb 24 05:27:58 2023 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PNJMF0Tl6z3tHXr for ; Fri, 24 Feb 2023 05:28:09 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gold.funkthat.com [IPv6:2001:470:800b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PNJMD0x2Kz4XBQ for ; Fri, 24 Feb 2023 05:28:07 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 2001:470:800b::2) smtp.mailfrom=jmg@gold.funkthat.com; dmarc=none Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 31O5RwnU012075 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 23 Feb 2023 21:27:59 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 31O5Rwvi012073; Thu, 23 Feb 2023 21:27:58 -0800 (PST) (envelope-from jmg) Date: Thu, 23 Feb 2023 21:27:58 -0800 From: John-Mark Gurney To: Konstantin Belousov Cc: Warner Losh , freebsd-arch@freebsd.org Subject: Re: making identify_hypervisor arch independent Message-ID: <20230224052758.GT95670@funkthat.com> Mail-Followup-To: Konstantin Belousov , Warner Losh , freebsd-arch@freebsd.org References: <20230222040556.GP95670@funkthat.com> <20230223002940.GS95670@funkthat.com> List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Thu, 23 Feb 2023 21:27:59 -0800 (PST) X-Spamd-Result: default: False [-1.80 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[freebsd-arch@freebsd.org]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEFALL_USER(0.00)[jmg]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[funkthat.com]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4PNJMD0x2Kz4XBQ X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N Konstantin Belousov wrote this message on Thu, Feb 23, 2023 at 06:53 +0200: > On Wed, Feb 22, 2023 at 04:29:40PM -0800, John-Mark Gurney wrote: > > Konstantin Belousov wrote this message on Wed, Feb 22, 2023 at 12:44 +0200: > > > On Tue, Feb 21, 2023 at 10:22:41PM -0700, Warner Losh wrote: > > > > On Tue, Feb 21, 2023 at 9:06 PM John-Mark Gurney wrote: > > > > > > > > > Hello, > > > > > > > > > > I have a pending diff (https://reviews.freebsd.org/D38721) that will make > > > > > SMBIOS work on arm64 systems (specifically under qemu, but likely it may > > > > > add support for other EFI arm64 systems that have SMBIOS as well). > > > > > > > > > > The goal is to support identifying that we are running as a guest under > > > > > QEMU so that we automatically switch to hz=100 on arm64. > > > > > > > > > > Currently there is code in x86/x86/identcpu.c that has code to identify > > > > > hypervisers via SMBIOS, so I'd like to move most of identify_hypervisor > > > > > to a new location so that arm64 code can call it as well. > > > > > > > > > > Where should I put it? kern/subr_identsmbios.c? And make it optional > > > > > on EFIRT for arm64 and standard on x86? > > > > > > > > I'd do kern/subr_smbios.c. > > > > > > > > I'd be tempted to make it standard, since EFI is basically required for > > > > arm64. It's not dependent at all on efi run time support. > > > Why not extend existing sys/dev/smbios? > > > > Because it's not a device like dev says it should be. > dev/ does not imply that code from there needs either cdev or newbus > attachment,it is for code that is to handle platform or device. smbios > fits perfectly into this description. > > Biggest example is dev/efidev, with its efirt/efirtc stuff. > Second would be dev/smbios. smbios isn't a good example, just a FYI, it IS a device driver, and it doesn't do anything except reserve a resource... > In fact, there is even stuff like dev/{xz,zlib}. Ok, I was just going on what sys/README.md says, I'll update that to make it clear that it isn't just for device drivers, and is any arch independent code. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."