From owner-freebsd-scsi@FreeBSD.ORG Tue May 25 18:52:29 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20A46106564A for ; Tue, 25 May 2010 18:52:29 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4DC608FC16 for ; Tue, 25 May 2010 18:52:27 +0000 (UTC) Received: by fxm17 with SMTP id 17so711452fxm.13 for ; Tue, 25 May 2010 11:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=VCPChNiC90tz1BxbD4coNsQlr9ZPQDuhEZhvMI/Mtuo=; b=B2xO9LwNrIrAjHmPLYduUYW59ySh2aUvbXsQf8I9EQ2Qa6zvSfit5qrAhSgXXRfPgE mzO81IwvxT+K23Kc4iN04Y/eL1iTlnZ+N8y4CER6ZslY25Bv8jS3aGTHai+vtrwPgF/7 0vu/ofRnXTF6ml7nwWxIcvz2SzYBZyNyv1fDY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=phkm6OOmMsu01M7SQDlqV3QFKQOlUNuqB1xNGQ7UCikiWMzOweXMqZaJ3y24iusVxM atlAzaQDTdzxNp4kYTMH9PCtqvIrMY5L5tlyn2kWKrKd6Q5ARNwNOaF4JAygfxsEUpaM HKbfn9P8DUzGHi0W7xFGXIxK9ESyZLjxODETg= Received: by 10.223.127.196 with SMTP id h4mr1750527fas.56.1274813547054; Tue, 25 May 2010 11:52:27 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id 15sm26042268fad.22.2010.05.25.11.52.25 (version=SSLv3 cipher=RC4-MD5); Tue, 25 May 2010 11:52:26 -0700 (PDT) Sender: Alexander Motin Message-ID: <4BFC1C57.4080703@FreeBSD.org> Date: Tue, 25 May 2010 21:52:07 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.24 (X11/20100402) MIME-Version: 1.0 To: Matthew Jacob , freebsd-scsi@freebsd.org References: <4BFB3985.1030301@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: patches for CAM SCSI probing, etc. X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2010 18:52:29 -0000 Matthew Jacob wrote: > Part of the reason I went the way you had done for ATA is to try and > guarantee one and one only probe action at a time per nexus. But in ATA I am restarting probe from the begining when new request arrive. Look on "softc->restart". >> you are slightly changing semantics of device probe. Previously, probe >> call means warranty that device will be probed from the beginning after >> the moment of request. It is very important for ATA, as probe function >> also initializes device, that is mandatory if probe is called as result >> of device reset. SCSI devices probably don't need that initialization, >> but what if probe was called due to inquiry change status received >> during probe sequence running? Are you sure you won't loose events here? -- Alexander Motin