From owner-cvs-src@FreeBSD.ORG Wed Oct 6 16:52:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12D7916A4CE; Wed, 6 Oct 2004 16:52:17 +0000 (GMT) Received: from ylpvm43.prodigy.net (ylpvm43-ext.prodigy.net [207.115.57.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id B09C043D31; Wed, 6 Oct 2004 16:52:14 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222])i96GqKCE008384; Wed, 6 Oct 2004 12:52:21 -0400 Message-ID: <416422BC.8030805@root.org> Date: Wed, 06 Oct 2004 09:52:12 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040901) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxim Maximov References: <200410061420.i96EKwvd040396@repoman.freebsd.org> <416410E5.7000405@mcsi.pp.ru> In-Reply-To: <416410E5.7000405@mcsi.pp.ru> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: Mike Makonnen cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libthr/threadthr_exit.csrc/sys/compat/freebsd32 syscalls.master src/sys/kern kern_thr.c src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2004 16:52:17 -0000 Maxim Maximov wrote: > Mike Makonnen wrote: > >> mtm 2004-10-06 14:20:58 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libthr/thread thr_exit.c sys/compat/freebsd32 >> syscalls.master sys/kern kern_thr.c >> sys/sys thr.h Log: >> Close a race between a thread exiting and the freeing of it's stack. >> After some discussion the best option seems to be to signal the >> thread's >> death from within the kernel. This requires that thr_exit() take an >> argument. >> Discussed with: davidxu, deischen, marcel >> MFC after: 3 days > > > Just cvsupped source fails to build: > > cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. > -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica > -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter > -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath > -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm > -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 > -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding > -Werror /usr/src/sys/kern/kern_thr.c > /usr/src/sys/kern/kern_thr.c: In function `thr_exit': > /usr/src/sys/kern/kern_thr.c:196: error: structure has no member named > `state' > /usr/src/sys/kern/kern_thr.c:197: error: structure has no member named > `state' > *** Error code 1 > > Stop in /usr/obj/usr/src/sys/ULTRA. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > Exit 1 It's because of the +0 -0 stuff in the commit. I think he did commit -f without regenerating the syscall table. -Nate