From owner-freebsd-hackers  Wed Apr  2 17:21:15 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id RAA14428
          for hackers-outgoing; Wed, 2 Apr 1997 17:21:15 -0800 (PST)
Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id RAA14412
          for <Hackers@FreeBSD.ORG>; Wed, 2 Apr 1997 17:21:10 -0800 (PST)
Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.5/CET-v2.1) with SMTP id BAA01306 for <Hackers@FreeBSD.ORG>; Thu, 3 Apr 1997 01:20:59 GMT
Date: Thu, 3 Apr 1997 10:20:58 +0900 (JST)
From: Michael Hancock <michaelh@cet.co.jp>
To: FreeBSD Hackers <Hackers@FreeBSD.ORG>
Subject: factoring of vput/vrele not good
Message-ID: <Pine.SV4.3.95.970403101452.1213A-100000@parkplace.cet.co.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-hackers@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

I don't think the factoring of some of the common code in vput and vrele
into vputrele was a very good idea.  The problem is that the locking
semantics are very different which makes it tricky.  Tricky code is
*evil*.

Factoring is a good habit in many cases, but sometimes we need to look at
other aspects of code quality than processor cache efficiencies or
whatever benefit that was used to make this decision.

Regards,


Mike Hancock