From owner-freebsd-virtualization@FreeBSD.ORG Wed Sep 3 19:00:52 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2D44106567A for ; Wed, 3 Sep 2008 19:00:52 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outI.internet-mail-service.net (outi.internet-mail-service.net [216.240.47.232]) by mx1.freebsd.org (Postfix) with ESMTP id B67898FC28 for ; Wed, 3 Sep 2008 19:00:52 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id A038B249C; Wed, 3 Sep 2008 12:00:52 -0700 (PDT) Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id D3CEC2D6043; Wed, 3 Sep 2008 12:00:51 -0700 (PDT) Message-ID: <48BEDEEA.6070602@elischer.org> Date: Wed, 03 Sep 2008 12:00:58 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: Robert Watson References: <20080828185639.P66593@maildrop.int.zabbadoz.net> <20080902000516.GA48622@lor.one-eyed-alien.net> <48BCED8E.5030109@elischer.org> <20080902141245.GB48622@lor.one-eyed-alien.net> <48BEB6FC.1070605@elischer.org> In-Reply-To: <48BEB6FC.1070605@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Bjoern A. Zeeb" , FreeBSD virtualization mailing list Subject: Re: Step 1.5 needs review X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2008 19:00:52 -0000 Julian Elischer wrote: > Robert Watson wrote: >> >> On Tue, 2 Sep 2008, Brooks Davis wrote: >> >>>> I suggest that we eventually replace: >>>> >>>> VNET_ITERLOOP_BEGIN >>>> stuff >>>> VNET_ITERLOOP_END >>>> >>>> >>>> with (eventually) >>>> >>>> FOREACH_VNET(vnet) { >>>> stuff >>>> } >>>> >>>> but that would require that the entire contents of "stuff" >>>> would appear in the diff. >>> >>> Thinking about it more, at a minimum, I think we should do: >>> VNET_ITERLOOP_BEGIN >>> stuff >>> VNET_ITERLOOP_END >> >> FWIW, I think we should make the change to FOREACH_VNET(vnet() { } >> sooner rather than later -- especially if there's no semantic change >> going on currently, now would be the time to do the indentation change. >> >>>> I'm not sure I want to actually include the contents directly into >>>> if.h or any other place.. I think keeping a separate vnet.h and >>>> vinet.h seems ok to me. >>> >>> The #ifdef _KERNEL is a strong hint that it belongs in if_var.h if >>> it's going to be included in another header (IMO, the vnet/vinet.h >>> files aren't a good idea in the long term). >> >> My views on this one are a bit mixed -- if the goal is to get, in the >> medium term, to a case where we do explicit dereferencing rather than >> macros, we may find we do need more globally visible types than we had >> before, which may require us to have new globally included headers. >> That said, in.h might be as good a place as any for global inet stuff, >> and as long as we have piles of pointers rather than nested structs, >> the type issue shouldn't get too bad. > > thats' where vinet is, but what about vnet.. (non inet stuff) > I have it off if.h right now.. moved to if_var.h > >> >> Robert N M Watson >> Computer Laboratory >> University of Cambridge > > _______________________________________________ > freebsd-virtualization@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization > To unsubscribe, send any mail to > "freebsd-virtualization-unsubscribe@freebsd.org"