From owner-freebsd-current@FreeBSD.ORG  Wed Aug 12 13:32:20 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 395F31065670;
	Wed, 12 Aug 2009 13:32:20 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 07DC38FC57;
	Wed, 12 Aug 2009 13:32:20 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 565E946B23;
	Wed, 12 Aug 2009 09:32:19 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id B8F488A0AD;
	Wed, 12 Aug 2009 09:32:18 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Wed, 12 Aug 2009 09:24:48 -0400
User-Agent: KMail/1.9.7
References: <wp8whraago.fsf@heho.snv.jussieu.fr>
	<20090811195240.GI1292@hoeg.nl> <4A81EEE8.5060405@elischer.org>
In-Reply-To: <4A81EEE8.5060405@elischer.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200908120924.49300.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Wed, 12 Aug 2009 09:32:18 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Ed Schouten <ed@80386.nl>, Kip Macy <kmacy@freebsd.org>,
	Robert Noland <rnoland@freebsd.org>,
	"Arno J. Klaassen" <arno@heho.snv.jussieu.fr>,
	Julian Elischer <julian@elischer.org>,
	FreeBSD Current <current@freebsd.org>
Subject: Re: 8.0-BETA2: mi_startup() panic on VIA C7 diskless
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Aug 2009 13:32:20 -0000

On Tuesday 11 August 2009 6:21:28 pm Julian Elischer wrote:
> Ed Schouten wrote:
> > * Kip Macy <kmacy@freebsd.org> wrote:
> >> http://people.freebsd.org/~kmacy/flowtable_boot.patch
> > 
> > +	if ((V_flowtable_enable == 0) || (V_flowtable_ready == 0)
> > 
> > should probably read:
> > 
> > +	if (V_flowtable_enable == 0 || V_flowtable_ready == 0)
> > 
> > Right?
> > 
> 
> 
> I prefer the first, with an extra closing paren.

style(9) prefers the latter assuming that it isn't confusing to read the 
latter (I do not think it is).

-- 
John Baldwin