From owner-freebsd-ports@FreeBSD.ORG Sat Dec 17 17:41:23 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C346106564A; Sat, 17 Dec 2011 17:41:23 +0000 (UTC) (envelope-from jbeich@tormail.net) Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77]) by mx1.freebsd.org (Postfix) with ESMTP id D75F18FC13; Sat, 17 Dec 2011 17:41:22 +0000 (UTC) Received: from vevomque.idxf.com ([85.17.122.79]:40480 helo=internal.tormail.net) by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.69) (envelope-from ) id 1RbxCA-0017P5-Ur; Sat, 17 Dec 2011 11:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tormail.net; s=tm; h=Message-Id:X-TorMail-User:Content-Type:MIME-Version:Date:References:In-Reply-To:Subject:Cc:To:From; bh=2kxwT6SovC97NBf1uiCnNj7AhjFuavhHuWhu+L1H6L8=; b=qPagGot2JtCVwm40VZaEa0vSMHthX08miiqEQ2LNjiFF2dDYg7G7zYdOepX0E+C7FbthEgERgpOHXY8X2CEYiKr43BdAEYk+03gaZHFMn64UPDDyTwJzVM8jN+DTGmRTNf4r/BEbE3wnaGDj7UoIcYqp6VvbV7NB1yZrBaTWJKM=; Received: from jbeich by internal.tormail.net with local (Exim 4.63) (envelope-from ) id 1RbxBi-0008Ls-5O; Sat, 17 Dec 2011 16:32:45 +0000 From: Jan Beich To: Chris Rees In-Reply-To: (Chris Rees's message of "Sat, 17 Dec 2011 15:52:07 +0000") References: Date: Sun, 18 Dec 2011 03:32:09 +1100 MIME-Version: 1.0 Content-Type: text/plain X-TorMail-User: jbeich Message-Id: <1RbxBi-0008Ls-5O@internal.tormail.net> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server2.hudsonvalleyhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tormail.net X-Source: X-Source-Args: X-Source-Dir: Cc: Christer Solskogen , garga@freebsd.org, freebsd-ports Subject: Re: Removal of use_gmake breaks lua X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 17:41:23 -0000 Chris Rees writes: >> as seen here: >> http://docs.freebsd.org/cgi/getmsg.cgi?fetch=295602+0+/usr/local/www/db/text/2011/cvs-all/20111113.cvs-all > > I don't like the proposed solution; it's less hackish to just use > gmake again; most people have it installed anyway.... A non-hackish solution would involve fixing sys.mk to guard against recursive inclusion of __MAKE_CONF. bsd.port.mk is known to have this when using make(1) for do-build. Not that I mind shoving the issue under the carpet by using gmake. Index: share/mk/sys.mk =================================================================== --- share/mk/sys.mk (revision 228500) +++ share/mk/sys.mk (working copy) @@ -306,10 +306,13 @@ YFLAGS ?= -d ${CTFCONVERT_CMD} # FreeBSD build pollution. Hide it in the non-POSIX part of the ifdef. +.if !defined(__MAKE_CONF_INCLUDED) +__MAKE_CONF_INCLUDED= __MAKE_CONF?=/etc/make.conf .if exists(${__MAKE_CONF}) .include "${__MAKE_CONF}" .endif +.endif .if defined(__MAKE_SHELL) && !empty(__MAKE_SHELL) SHELL= ${__MAKE_SHELL}