Date: Sun, 22 May 2022 12:37:12 +0200 From: Stefan Esser <se@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: freebsd-ports@freebsd.org Subject: Re: NO_TEST, do-test: and TEST_DEPENDS? Message-ID: <848ba292-d306-dcd7-2456-383f1a3652f6@FreeBSD.org> In-Reply-To: <alpine.BSF.2.00.2205211433520.68830@ai.fobar.qr> References: <alpine.BSF.2.00.2205211433520.68830@ai.fobar.qr>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PK6bQXAev0s2y1SjoeEkQ3rY Content-Type: multipart/mixed; boundary="------------abnE5RafK58k8GiI530sH2Ix"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: freebsd-ports@freebsd.org Message-ID: <848ba292-d306-dcd7-2456-383f1a3652f6@FreeBSD.org> Subject: Re: NO_TEST, do-test: and TEST_DEPENDS? References: <alpine.BSF.2.00.2205211433520.68830@ai.fobar.qr> In-Reply-To: <alpine.BSF.2.00.2205211433520.68830@ai.fobar.qr> --------------abnE5RafK58k8GiI530sH2Ix Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 21.05.22 um 16:37 schrieb Bjoern A. Zeeb: > Hi, >=20 > I just grabbed a random example and made put the NO_TEST into the Makef= ile to > make things clear. Hi Bjoern, I'm not sure I understand the goal of your request. Do you want to have a switch that prevents the execution of tests when "make test" explicitly asks for the tests to be run??? This could easily be added to bsd.port.mk, but what for??? > What is the proper way to > =C2=A0=C2=A0=C2=A0=C2=A0(1) disable tests That's what I do not understand ... Tests are not run by default, and thus I never saw the need to disable them in any of my ports. Quite the opposite: If "make test" is invoked for a port that supports tests, I definitely want them to be executed. > and more important > =C2=A0=C2=A0=C2=A0=C2=A0(2) to amke sure the TEST_DEPENDS and not build= in these cases? You can set "DO_MAKE_TEST=3Dtrue" to execute the command "true" instead of "make" when bsd.port.mk wants to execute the tests. But this is an undocumented internal variable of the ports system, and it could be removed or renamed at any time, when changes are applied to bsd.port.mk. And you could override the TEST_DEPENDS macro instead of wrapping it into an .if block. > While I can iterate on port after port and apply a change like the belo= w it > feels utterly wrong and it seems I am doing something silly here which = has a > proper knob I cannot find? Please explain what you want to achieve. There may be other ways to achieve your goal, but I think I do not understand what your goal is ... Regards, STefan --------------abnE5RafK58k8GiI530sH2Ix-- --------------PK6bQXAev0s2y1SjoeEkQ3rY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmKKElgFAwAAAAAACgkQR+u171r99USA GQgAwTyJUycrgMHt4JTBsc6B9A/ZPjSSu+PyAJ4nYASBMDxEXNxmQqHB9E3oN85JTjAfmzyGcAJN GZMaLvwDDaBkfE3B7nC3I/asqxNX1SxZKfrh9YS85cQechtBH2OzE0I01KQdrQ7QiOww+Kmh3uv3 flUxa2k5ZQsDkogeZXvwq0oS4HqAqrpeij/gvN+YjmqCMz4O2AsvDW3xEU86KgOudbytEwzlhZ87 fbqvSc9WI7vkvmL6u4sUjRmfvo+ZrApXxAZpqwDXEaJP8FISbrHTgMgeCo7YXL5wSIikhNX70/Zd pl/Rzgs5BqcLTio5KauLos+/Yr1c9MjtxezWXUuqTg== =2ipU -----END PGP SIGNATURE----- --------------PK6bQXAev0s2y1SjoeEkQ3rY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?848ba292-d306-dcd7-2456-383f1a3652f6>