From owner-cvs-src@FreeBSD.ORG  Tue Nov 18 16:46:26 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9398F16A4CF
	for <cvs-src@FreeBSD.org>; Tue, 18 Nov 2003 16:46:26 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9D62043FE5
	for <cvs-src@FreeBSD.org>; Tue, 18 Nov 2003 16:46:22 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 65757 invoked by uid 1000); 19 Nov 2003 00:46:24 -0000
Date: Tue, 18 Nov 2003 16:46:24 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Mark Murray <markm@FreeBSD.org>
In-Reply-To: <20031119111015.E5018@gamplex.bde.org>
Message-ID: <20031118163849.S65744@root.org>
References: <200311181435.hAIEZhtY048135@repoman.freebsd.org>
 <20031119111015.E5018@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_intr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 00:46:26 -0000

On Wed, 19 Nov 2003, Bruce Evans wrote:
> On Tue, 18 Nov 2003, Mark Murray wrote:
>
> > markm       2003/11/18 06:35:43 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             kern_intr.c
> >   Log:
> >   Hackfix to patch around a kernel panic I introduced. Real fix to
> >   follow. In the meanwhile, we are not harvesting interrupt entropy.
> >
> >   Approved by:    re (jhb)
>
> The correct fix is approximately to back out the changes to the
> harvester.  It needs to use preallocated storage like it used to since
> it is called from nearly the lowest level of interrupt handling when
> neither malloc() nor sleep locks may be used.  Using preallocated storage
> also simplifies the locking.

I agree.  Separating the buffer into per-source buffers does not require
changing from a ring buffer to a malloc/FIFO model.

-Nate