From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 14 23:20:15 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3294716A41F for ; Sun, 14 Aug 2005 23:20:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB44943D49 for ; Sun, 14 Aug 2005 23:20:14 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7ENKEu2015760 for ; Sun, 14 Aug 2005 23:20:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7ENKEFO015759; Sun, 14 Aug 2005 23:20:14 GMT (envelope-from gnats) Resent-Date: Sun, 14 Aug 2005 23:20:14 GMT Resent-Message-Id: <200508142320.j7ENKEFO015759@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Antoine Pelisse Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D042E16A41F for ; Sun, 14 Aug 2005 23:15:06 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id A16D043D46 for ; Sun, 14 Aug 2005 23:15:06 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j7ENF6am083079 for ; Sun, 14 Aug 2005 23:15:06 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j7EMlHkr055715; Sun, 14 Aug 2005 22:47:17 GMT (envelope-from nobody) Message-Id: <200508142247.j7EMlHkr055715@www.freebsd.org> Date: Sun, 14 Aug 2005 22:47:17 GMT From: Antoine Pelisse To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: kern/84935: [PATCH] Panic in kern_exec.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2005 23:20:15 -0000 >Number: 84935 >Category: kern >Synopsis: [PATCH] Panic in kern_exec.c >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 14 23:20:14 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Antoine Pelisse >Release: 7-CURRENT >Organization: Xloling >Environment: FreeBSD 7.0-CURRENT: Sun Aug 14 23:38:35 CEST 2005 >Description: Fix for panic: http://people.freebsd.org/~pho/stress/log/cons151.html >How-To-Repeat: >Fix: --- kern/kern_exec.c.orig Sun Aug 14 22:39:41 2005 +++ kern/kern_exec.c Sun Aug 14 22:43:16 2005 @@ -667,7 +667,14 @@ /* Cache arguments if they fit inside our allowance */ if (ps_arg_cache_limit >= i + sizeof(struct pargs)) { + /* + * the lock needs to be released as begin_argv is + * stored in pageable memory (allocated with + * kmem_alloc_wait) + */ + PROC_UNLOCK(p); bcopy(imgp->args->begin_argv, newargs->ar_args, i); + PROC_LOCK(p); p->p_args = newargs; newargs = NULL; } Feel free to modify the comment, Regards. >Release-Note: >Audit-Trail: >Unformatted: