From owner-freebsd-ports@FreeBSD.ORG Sat Nov 13 02:18:20 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C826106564A for ; Sat, 13 Nov 2010 02:18:20 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4BF058FC16 for ; Sat, 13 Nov 2010 02:18:19 +0000 (UTC) Received: by vws20 with SMTP id 20so1229425vws.13 for ; Fri, 12 Nov 2010 18:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=xoqrAm0qokEyNCqUv63eFKZ/xh3tj/+tNSLalGDCntM=; b=x8iRsZg4iAkJf3/3jqCN2eP5J7yNWNlUeB+fqMSgJKEv2q2pV1324+LlWAHdHVm+u0 fin3b5UX26MXOm0Q6YQag6cUpRuvyKlfO3mSKIF511PeYzbxXi1W6W/1l7G6KVprmXYT rimTmuSbiWvAs3Op0gFs7EH9kYvYIxGMOd7Jo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=PNoCtHxl2vyY04mkGXCjXUSrlGB9+aYM19JSGfKTXmZeobSPvhP/Ih74Abxfj4K/Pe mgasWm6a+I9rZmaNQ2bR51djq+afuTh4DcXU+x5aVWdM+RNSCng6yNx9TStnU/lKXChs q1mazIjiD8Yj0hkGB1G41zxDiO0BVnEqKZ0oo= Received: by 10.220.193.4 with SMTP id ds4mr687618vcb.99.1289614698195; Fri, 12 Nov 2010 18:18:18 -0800 (PST) Received: from localhost ([208.53.142.42]) by mx.google.com with ESMTPS id p30sm1112301vcf.26.2010.11.12.18.18.15 (version=SSLv3 cipher=RC4-MD5); Fri, 12 Nov 2010 18:18:17 -0800 (PST) From: Anonymous To: Michal Varga References: <86k4kim5rl.fsf@gmail.com> <1289609730.1517.16.camel@xenon> Date: Sat, 13 Nov 2010 05:18:07 +0300 In-Reply-To: <1289609730.1517.16.camel@xenon> (Michal Varga's message of "Sat, 13 Nov 2010 01:55:30 +0100") Message-ID: <861v6qge5c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: thomas.e.zander@googlemail.com, Christian Weisgerber , freebsd-ports@freebsd.org Subject: Re: [CFT] mplayer / mencoder port update X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Nov 2010 02:18:20 -0000 Michal Varga writes: > On Sat, 2010-11-13 at 03:22 +0300, Anonymous wrote: >> Can you try to replace >> >> #ifdef __FreeBSD__ >> >> with >> >> #ifdef __FreeBSD__ && __FreeBSD_version >= 800097 >> >> Alternatively, just hide the patch under ${OSVERSION} >= 800097. > > Just my 2 cents: > > Wouldn't be easier to simply made the patch optional via OPTIONS > (defaulting to off) and forget about it? > > For example, I too have no use for it, as I don't prefer applications > messing with my mixer and thus run mplayer with -sotfvol. And seriously, > even then, for the past 10 years of pretty heavy mplayer usage - I > changed volume in it for like.. three times, ever (probably by > accident). VPC is smth like an application-specific mixer. And you can even change volume for apps that don't normally have any volume control, e.g. audio/xmp. http://people.freebsd.org/~ariff/utils/appsmixer OTOH, -softvol is mplayer-specific. > > So for me, this is a patch that's not part of $Upstream, does absolutely > nothing I need, does even less for 4Front OSS users, and is already > known to break stuff for someone (the last point being somewhat > significant). It was an attempt to make volume control more user-friendly on 8.x packages. For example 1. user opens a file and finds out volume is too high 3. so, he reduces it using volume control buttons (`/' and `*') 4. after a bit of time he pauses playback (e.g. to get more snacks) 5. then resumes playback only to find out volume is back to high And the above doesn't happen on 6.x or 7.x. But on 8.x one has to dig mplayer manpage for -softvol even if he previously didn't use it. > > Please, don't include it by default for everyone. If it's not gonna be included by default there should be a note in PKGMESSAGE about how VPC on 8.x affects volume control in mplayer and a suggestion to use -softvol.