From owner-freebsd-arch Thu Jun 8 18:11:40 2000 Delivered-To: freebsd-arch@freebsd.org Received: from cypherpunks.ai (cypherpunks.ai [209.88.68.47]) by hub.freebsd.org (Postfix) with ESMTP id 7A9C137BD37; Thu, 8 Jun 2000 18:11:37 -0700 (PDT) (envelope-from jeroen@vangelderen.org) Received: from vangelderen.org (grolsch.ai [209.88.68.214]) by cypherpunks.ai (Postfix) with ESMTP id 4A8D288; Thu, 8 Jun 2000 21:11:36 -0400 (AST) Message-ID: <39404448.4435649A@vangelderen.org> Date: Thu, 08 Jun 2000 21:11:36 -0400 From: "Jeroen C. van Gelderen" X-Mailer: Mozilla 4.72 [en] (X11; I; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Mark Murray Cc: arch@FreeBSD.ORG, bde@FreeBSD.ORG, dfr@FreeBSD.ORG, pkh@FreeBSD.ORG Subject: Re: (3rd iteration) New /dev/(random|null|zero) - review, please References: <200006082058.WAA01487@grimreaper.grondar.za> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Mark Murray wrote: > > (Some more improvements have been done - 3rd iteration) > > Hi > > I have finished doing a MI /dev/null and /dev/zero, and I have got a > new /dev/random. I'm looking for reviewers. > > The code is in http://freefall.freebsd.org/~markm/. There is a tar > file and diffs (all for the sys/ area). Some other supplementary patches > are needed in userland, these are not included. > > I like to think that this is a commit candidate. Please review as such. The module allows unloads even when users have the devices open. I think you need to do reference counting. The misc device already does that and has been tested already. You know the URL. The device is named nulldev. PHK suggested that misc is the preferred name. I'd personally prefer 'rathole' though ;-) Cheers, Jeroen -- Jeroen C. van Gelderen o _ _ _ jeroen@vangelderen.org _o /\_ _ \\o (_)\__/o (_) _< \_ _>(_) (_)/<_ \_| \ _|/' \/ (_)>(_) (_) (_) (_) (_)' _\o_ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message