From owner-freebsd-bugs@FreeBSD.ORG  Fri Aug 15 19:20:10 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 271BA37B401
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 15 Aug 2003 19:20:10 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BCE4743F3F
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 15 Aug 2003 19:20:09 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7G2K9Up054710
	for <freebsd-bugs@freefall.freebsd.org>;
	Fri, 15 Aug 2003 19:20:09 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7G2K9jQ054709;
	Fri, 15 Aug 2003 19:20:09 -0700 (PDT)
Date: Fri, 15 Aug 2003 19:20:09 -0700 (PDT)
Message-Id: <200308160220.h7G2K9jQ054709@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Doug White <dwhite@gumbysoft.com>
Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Doug White <dwhite@gumbysoft.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Aug 2003 02:20:10 -0000

The following reply was made to PR bin/55346; it has been noted by GNATS.

From: Doug White <dwhite@gumbysoft.com>
To: Eugene Grosbein <eugen@grosbein.pp.ru>
Cc: stable@freebsd.org, bug-followup@freebsd.org
Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely
Date: Fri, 15 Aug 2003 19:13:57 -0700 (PDT)

 On Fri, 15 Aug 2003, Eugene Grosbein wrote:
 
 > I think I've found a memory leak in /bin/sh.
 > There is a case when dowait() and does frees resources of
 > completed job correctly. Here is a patch:
 
 Your idea has some merit but your patch does not conform to normal style.
 
 > -#if JOBS
 >  					if (done)
 > -						deljob(jp);
 > -#endif
 > +					    freejob(jp);
 
 You should not remove the ifdef and change the indentation of deljob. Just
 s/del/free and be done with it :-)  I highly doubt anyone needs to disable
 job control in sh, but in the off chance they do, you might as well keep
 the ifdef around.
 
 Note that freejob calls deljob.
 
 -- 
 Doug White                    |  FreeBSD: The Power to Serve
 dwhite@gumbysoft.com          |  www.FreeBSD.org