From owner-svn-src-head@FreeBSD.ORG Fri Jul 24 17:54:50 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B30671065670; Fri, 24 Jul 2009 17:54:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 8494B8FC15; Fri, 24 Jul 2009 17:54:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 39BC046B2E; Fri, 24 Jul 2009 13:54:50 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 6974C8A09D; Fri, 24 Jul 2009 13:54:49 -0400 (EDT) From: John Baldwin To: Jack F Vogel Date: Fri, 24 Jul 2009 13:54:34 -0400 User-Agent: KMail/1.9.7 References: <200907241657.n6OGvoQX015880@svn.freebsd.org> In-Reply-To: <200907241657.n6OGvoQX015880@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907241354.34889.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 24 Jul 2009 13:54:49 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195851 - in head/sys/dev: e1000 ixgbe X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2009 17:54:51 -0000 On Friday 24 July 2009 12:57:50 pm Jack F Vogel wrote: > Author: jfv > Date: Fri Jul 24 16:57:49 2009 > New Revision: 195851 > URL: http://svn.freebsd.org/changeset/base/195851 > > Log: > This delta fixes two bugs: > - When a vlan event occurs a check was not made that > the event was actually for the interface, thus resulting > in a panic. All three drivers have this vulnerability. Add > a check for this condition. These are still not correct. You need to check the softc as in the latest patch I sent. Otherwise if you have multiple em(4) or igb(4) interfaces in a machine you will register vlan's on all the em/igb interfaces multiple times. E.g., if you added a em0.500 and em1.502, you would actually end up with both em0 and em1 doing hardware tagging for both vlans 500 and 502. -- John Baldwin