From owner-cvs-src-old@FreeBSD.ORG  Thu Nov 11 11:54:17 2010
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 89C91106564A
	for <cvs-src-old@freebsd.org>; Thu, 11 Nov 2010 11:54:17 +0000 (UTC)
	(envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 774078FC18
	for <cvs-src-old@freebsd.org>; Thu, 11 Nov 2010 11:54:17 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oABBsHgN029932
	for <cvs-src-old@freebsd.org>; Thu, 11 Nov 2010 11:54:17 GMT
	(envelope-from kib@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oABBsHq4029931
	for cvs-src-old@freebsd.org; Thu, 11 Nov 2010 11:54:17 GMT
	(envelope-from kib@repoman.freebsd.org)
Message-Id: <201011111154.oABBsHq4029931@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	kib@repoman.freebsd.org using -f
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Thu, 11 Nov 2010 11:54:01 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/ufs/ffs ffs_softdep.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Nov 2010 11:54:17 -0000

kib         2010-11-11 11:54:01 UTC

  FreeBSD src repository

  Modified files:
    sys/ufs/ffs          ffs_softdep.c 
  Log:
  SVN rev 215117 on 2010-11-11 11:54:01Z by kib
  
  The softdep_setup_freeblocks() adds worklist items before
  deallocate_dependencies() is done. This opens a race between softdep
  thread and the thread that does the truncation:
    A write of the indirect block causes the freeblks to become
    ALLCOMPLETE while softdep_setup_freeblocks() dropped softdep lock. And
    then, softdep_disk_write_complete() would reassign the workitem to the
    mount point worklist, causing premature processing of the workitem, or
    journal write exhaust the fb_jfreeblkhd and handle_written_jfreeblk does
    the same reassign.
  indir_trunc() then would find the indirect block that is locked (with lock
  owned by kernel) but without any dependencies, causing it to hang in
  getblk() waiting for buffer lock.
  
  Do not mark freeblks as DEPCOMPLETE until deallocate_dependencies()
  finished.
  
  Analyzed, suggested and reviewed by:    jeff
  Tested by:      pho
  
  Revision  Changes    Path
  1.256     +5 -2      src/sys/ufs/ffs/ffs_softdep.c