From owner-freebsd-ports@FreeBSD.ORG  Fri Oct  7 12:38:06 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5D0681065670;
	Fri,  7 Oct 2011 12:38:06 +0000 (UTC) (envelope-from ken@kdm.org)
Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81])
	by mx1.freebsd.org (Postfix) with ESMTP id 228638FC13;
	Fri,  7 Oct 2011 12:38:06 +0000 (UTC)
Received: from nargothrond.kdm.org (localhost [127.0.0.1])
	by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id p97CEtEO039180;
	Fri, 7 Oct 2011 06:14:55 -0600 (MDT)
	(envelope-from ken@nargothrond.kdm.org)
Received: (from ken@localhost)
	by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id p97CEtBC039179;
	Fri, 7 Oct 2011 06:14:55 -0600 (MDT) (envelope-from ken)
Date: Fri, 7 Oct 2011 06:14:55 -0600
From: "Kenneth D. Merry" <ken@FreeBSD.org>
To: bf1783@gmail.com
Message-ID: <20111007121455.GA39154@nargothrond.kdm.org>
References: <CAGFTUwOXZ2sCf_nMUatjjPdC0XnVn+Z9DyYnwtOnUrS1nUS=tg@mail.gmail.com>
	<20111007121113.GA36879@nargothrond.kdm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20111007121113.GA36879@nargothrond.kdm.org>
User-Agent: Mutt/1.4.2i
Cc: ports@FreeBSD.org, danfe@FreeBSD.org, multimedia@FreeBSD.org
Subject: Re: audio/cdparanoia broken on -CURRENT, and probably on 9.0
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Oct 2011 12:38:06 -0000

On Fri, Oct 07, 2011 at 06:11:13 -0600, Kenneth D. Merry wrote:
> On Fri, Oct 07, 2011 at 03:46:22 -0400, b. f. wrote:
> > Just a note to say that recent changes on -CURRENT (r225950, meaning
> > that it is probably broken on 9.0 after r226067) have broken
> > audio/cdparanoia, and it should be fixed or marked as BROKEN there.  I
> > haven't filed a PR, or attempted to patch it yet -- I think that it
> > would be worthwhile to look into moving to 10.2, which has a large
> > number of improvements, although suffering from some Linuxisms.
> 
> This will be easy to patch, using one of two methods:
> 
>  - change struct scsi_sense_data to struct scsi_sense_data_fixed
> or, better yet:
>  - use scsi_extract_sense_len(), which will work for fixed or descriptor
>    sense.

I should have also mentioned that this should be dependent on CAM_VERSION
>= 0x16.

Ken
-- 
Kenneth Merry
ken@FreeBSD.org