Date: Tue, 11 Mar 2014 23:37:25 GMT From: Christophe Juniet <c.juniet@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/187462: [patch] x11/rxvt-unicode mousewheel support with clang Message-ID: <201403112337.s2BNbPaV086339@cgiserv.freebsd.org> Resent-Message-ID: <201403112340.s2BNe00u059194@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 187462 >Category: ports >Synopsis: [patch] x11/rxvt-unicode mousewheel support with clang >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 11 23:40:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Christophe Juniet >Release: 10.0-STABLE >Organization: >Environment: FreeBSD fbsd 10.0-STABLE FreeBSD 10.0-STABLE #0 r262848: Thu Mar 6 14:46:20 CET 2014 root@fbsd:/usr/obj/usr/src/sys/CUSTOM amd64 >Description: rxvt-unicode segfaults when trying to scroll with the mouse wheel if compiled with Clang so this option still implies USE_GCC=YES. The attached patch will fix the problem so GCC is not necessary anymore. >How-To-Repeat: Compile rxvt-unicode with mousewheel support with Clang. >Fix: Use the attached patch or see src/rxvt.h revision 1.526 of upstream. Patch attached with submission follows: diff -ruN /usr/ports/x11/rxvt-unicode/Makefile rxvt-unicode/Makefile --- /usr/ports/x11/rxvt-unicode/Makefile 2014-03-10 21:55:20.000000000 +0100 +++ rxvt-unicode/Makefile 2014-03-12 00:10:50.000000000 +0100 @@ -3,7 +3,7 @@ PORTNAME= rxvt-unicode PORTVERSION= 9.19 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= x11 MASTER_SITES= http://dist.schmorp.de/rxvt-unicode/%SUBDIR%/ MASTER_SITE_SUBDIR= . Attic @@ -129,8 +129,6 @@ # enable scrolling via mouse wheel or buttons 4 & 5 .if !${PORT_OPTIONS:MMOUSEWHEEL} CONFIGURE_ARGS+= --disable-mousewheel -.else -USE_GCC= yes # segfaults when trying to scroll with the mouse wheel if clang .endif # enable smart resize diff -ruN /usr/ports/x11/rxvt-unicode/files/patch-src_rxvt.h rxvt-unicode/files/patch-src_rxvt.h --- /usr/ports/x11/rxvt-unicode/files/patch-src_rxvt.h 1970-01-01 01:00:00.000000000 +0100 +++ rxvt-unicode/files/patch-src_rxvt.h 2014-03-12 00:10:50.000000000 +0100 @@ -0,0 +1,11 @@ +--- src/rxvt.h.orig 2013-10-03 01:05:18.000000000 +0200 ++++ src/rxvt.h 2014-03-12 00:02:43.000000000 +0100 +@@ -1540,7 +1540,7 @@ + bool scr_page (int nlines) NOTHROW; + bool scr_page (enum page_dirn direction, int nlines) NOTHROW + { +- scr_page (direction * nlines); ++ return scr_page (direction * nlines); + } + bool scr_changeview (int new_view_start) NOTHROW; + void scr_bell () NOTHROW; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403112337.s2BNbPaV086339>