From owner-freebsd-acpi@FreeBSD.ORG Mon Nov 21 22:25:53 2005 Return-Path: X-Original-To: acpi@freebsd.org Delivered-To: freebsd-acpi@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 855DE16A41F; Mon, 21 Nov 2005 22:25:53 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id E785A43D45; Mon, 21 Nov 2005 22:25:52 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id jALMPnDe015484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 21 Nov 2005 14:25:54 -0800 Message-ID: <4382494B.8020800@root.org> Date: Mon, 21 Nov 2005 14:25:15 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mathieu Prevot References: <200511171725.27877.jhb@freebsd.org> <437D04FC.90707@root.org> <200511171750.52720.jhb@freebsd.org> <200511211353.01664.jhb@freebsd.org> <314C3BAA-CBE8-42D8-B2F0-CEC9756F7550@club-internet.fr> In-Reply-To: <314C3BAA-CBE8-42D8-B2F0-CEC9756F7550@club-internet.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: acpi@freebsd.org Subject: Re: [PATCH] Fix weird PCI bus numbers with pci_linkX X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2005 22:25:53 -0000 Mathieu Prevot wrote: > > Le 21 nov. 05 à 19:53, John Baldwin a écrit : > >> On Thursday 17 November 2005 05:50 pm, John Baldwin wrote: >> >>> On Thursday 17 November 2005 05:32 pm, Nate Lawson wrote: >>> >>>> John Baldwin wrote: >>>> >>>>> I think I figured out why some people get messages like: >>>>> >>>>> pci_linkX: BIOS IRQ 11 for -17777216.6.INTA is invalid >>>>> >>>>> I was not reading the bus number from the bridge device correctly >>>>> (the >>>>> normal __BUS_ACCESSOR() macros assume that the passed in argument >>>>> is a >>>>> child device, but at the time I'm reading the bus there is no child >>>>> device, so I was passing in the pcib device, the parent of the pcib >>>>> device probably returned an error, and the bus variable ended up >>>>> being >>>>> some random stack garbage). The attached patch (also at URL) >>>>> should fix >>>>> it I think. >>>>> >>>>> http://www.FreeBSD.org/~jhb/patches/acpi_pci_link.patch >>>> >>>> >>>> Excellent, patch looks good to me except the printf/panic message >>>> could >>>> be improved. >>> >>> >>> I wanna see if it triggers first. >> >> >> So did anyone test this? I can't commit it unless someone tests it. >> > > Ok John. I'll test it. I have two motherboards with the problem. But I > am very busy so give me one or two days. Just cvsup, it's already tested by 1 person and in -current now. -- Nate