From owner-freebsd-virtualization@freebsd.org Wed Nov 15 14:19:51 2017 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BE32DDE0F6 for ; Wed, 15 Nov 2017 14:19:51 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C27236CAAE; Wed, 15 Nov 2017 14:19:50 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id vAFEJlUj074122; Wed, 15 Nov 2017 15:19:47 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 3F1BEC8B; Wed, 15 Nov 2017 15:19:47 +0100 (CET) Message-ID: <5A0C4CFF.7040902@omnilan.de> Date: Wed, 15 Nov 2017 15:19:43 +0100 From: Harry Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Peter Grehan CC: freebsd-virtualization@freebsd.org Subject: Re: pci_virtio_block.c Assertion failed: line 216 References: <586BFC91.4090404@omnilan.de> <2a8308c3-1570-08a3-a993-0f699fcd267d@freebsd.org> In-Reply-To: <2a8308c3-1570-08a3-a993-0f699fcd267d@freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Wed, 15 Nov 2017 15:19:47 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 14:19:51 -0000 Bezüglich Peter Grehan's Nachricht vom 03.01.2017 20:36 (localtime): > Hi Harry, > >> trying to use bhyve(8) with virtio-blk and Windows guest results in core >> dump: >> Assertion failed: (n >= 2 && n <= BLOCKIF_IOV_MAX + 2), function >> pci_vtblk_proc, file usr.sbin/bhyve/pci_virtio_block.c, line >> 216. >> Abort trap (core dumped) >> >> Unfortunately this is on a production-test machine which lacks gdb etc. >> Will try to reproduce on antoher machine, but maybe someone already >> knows that problem? > > virtio-blk isn't currently supported with Windows guests. You'll need > to use ahci-hd for now. > > However, I do have a fix that can hopefully be committed shortly. … Mising in another reply: >> Wiadomość napisana przez Harry Schmalzbauer > > w dniu 03.01.2017, o godz. 20:33: … >> Will try to reproduce on antoher machine, but maybe someone already >> knows that problem? > > I've seen that problem and fixed it, will upstream the patch later today. > > JFYI, fixing > commit: https://github.com/freenas/os/commit/0e4d6e1826f8aa7041cbeeb4365c797eeec5c5f4 Thanks Jakub for the info. I can confirm that increasing BLOCKIF_IOV_MAX from 33 to 128, like the diff shows, solved the problem for me. I've successfully done some performace tests on Windows7 (virtio-blk vs. ahci,hd:) and also migrated one Server 2012R2 to bhyve using virtio-blk. Peter, is your mentioned fix different from just increasing BLOCKIF_IOV_MAX? If not, would you commit that please? Thanks, -harry