Date: Mon, 21 Nov 2005 14:25:15 -0800 From: Nate Lawson <nate@root.org> To: Mathieu Prevot <bsdhack@club-internet.fr> Cc: acpi@freebsd.org Subject: Re: [PATCH] Fix weird PCI bus numbers with pci_linkX Message-ID: <4382494B.8020800@root.org> In-Reply-To: <314C3BAA-CBE8-42D8-B2F0-CEC9756F7550@club-internet.fr> References: <200511171725.27877.jhb@freebsd.org> <437D04FC.90707@root.org> <200511171750.52720.jhb@freebsd.org> <200511211353.01664.jhb@freebsd.org> <314C3BAA-CBE8-42D8-B2F0-CEC9756F7550@club-internet.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Prevot wrote: > > Le 21 nov. 05 à 19:53, John Baldwin a écrit : > >> On Thursday 17 November 2005 05:50 pm, John Baldwin wrote: >> >>> On Thursday 17 November 2005 05:32 pm, Nate Lawson wrote: >>> >>>> John Baldwin wrote: >>>> >>>>> I think I figured out why some people get messages like: >>>>> >>>>> pci_linkX: BIOS IRQ 11 for -17777216.6.INTA is invalid >>>>> >>>>> I was not reading the bus number from the bridge device correctly >>>>> (the >>>>> normal __BUS_ACCESSOR() macros assume that the passed in argument >>>>> is a >>>>> child device, but at the time I'm reading the bus there is no child >>>>> device, so I was passing in the pcib device, the parent of the pcib >>>>> device probably returned an error, and the bus variable ended up >>>>> being >>>>> some random stack garbage). The attached patch (also at URL) >>>>> should fix >>>>> it I think. >>>>> >>>>> http://www.FreeBSD.org/~jhb/patches/acpi_pci_link.patch >>>> >>>> >>>> Excellent, patch looks good to me except the printf/panic message >>>> could >>>> be improved. >>> >>> >>> I wanna see if it triggers first. >> >> >> So did anyone test this? I can't commit it unless someone tests it. >> > > Ok John. I'll test it. I have two motherboards with the problem. But I > am very busy so give me one or two days. Just cvsup, it's already tested by 1 person and in -current now. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4382494B.8020800>