From nobody Wed Dec 21 17:18:37 2022 X-Original-To: stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NcgCC59zgz1GGR5 for ; Wed, 21 Dec 2022 17:18:47 +0000 (UTC) (envelope-from jgibbons@protogate.com) Received: from gateway.protogate.com (gw.protogate.com [104.51.32.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "jag6.cmr.protogate.com", Issuer "jag6.cmr.protogate.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NcgCC2BNGz3mDm for ; Wed, 21 Dec 2022 17:18:47 +0000 (UTC) (envelope-from jgibbons@protogate.com) Authentication-Results: mx1.freebsd.org; none Received-SPF: pass (gateway.protogate.com: domain of jgibbons@gateway.protogate.com designates 127.0.0.1 as permitted sender) receiver=gateway.protogate.com; client-ip=127.0.0.1; helo=gateway.protogate.com; envelope-from=jgibbons@gateway.protogate.com; x-software=spfmilter 2.001 http://www.acme.com/software/spfmilter/ with libspf2-1.2.10; Received: from gateway.protogate.com (localhost [127.0.0.1]) by gateway.protogate.com (8.16.1/8.16.1) with ESMTPS id 2BLHIdeR006461 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 21 Dec 2022 09:18:39 -0800 (PST) (envelope-from jgibbons@gateway.protogate.com) Received: (from jgibbons@localhost) by gateway.protogate.com (8.16.1/8.16.1/Submit) id 2BLHIcPZ006460; Wed, 21 Dec 2022 09:18:38 -0800 (PST) (envelope-from jgibbons) Date: Wed, 21 Dec 2022 09:18:37 -0800 From: Jeff Gibbons To: stable@freebsd.org Cc: Per olof Ljungmark Subject: Re: Help with git - fetch earlier src version Message-ID: Mail-Followup-To: Jeff Gibbons , stable@freebsd.org, Per olof Ljungmark References: <3eae7bee-d0e2-da47-bd15-cf9f72d583ff@nethead.se> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3eae7bee-d0e2-da47-bd15-cf9f72d583ff@nethead.se> X-Virus-Scanned: clamav-milter 0.104.2 at gateway.protogate.com X-Virus-Status: Clean X-Rspamd-Queue-Id: 4NcgCC2BNGz3mDm X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7018, ipnet:104.48.0.0/12, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N I had that problem with my T490 laptop too, but it is fixed now for me in the latest 13/stable. I think this commit fixed it: root@thinker:/usr/src/sys/compat/linuxkpi/common/include/linux # git log rbtree.h commit 9d4303dbe2c4a901418657ed09c9f7096756e8b3 Author: Doug Moore Date: Mon Dec 19 16:03:13 2022 -0600 rb_tree: fix stable/13 linux/rbtree.h post ABI fix Rearranging the left, right, and parent pointers for backward compatibility with stable/13 in d8a88ec381498f5942403088d28ee325b92e9a78 is incomplete because it does not change linux/rbtree.h so that it too knows how rb_left and rb_right are redefined. So complete it. Reported by: jon_xyinn.org, jgibbons@protogate.org Tested by: manu, jon_xyinn.org Differential Revision: https://reviews.freebsd.org/D37743 I did a "cd /usr/src; git pull --rebase" at Dec 21 08:47 UTC to update my /usr/src, and that pulled in the above commit. I then rebuilt and installed the world and kernel with that sourcecode, then rebooted and rebuilt /usr/ports/graphics/drm-510-kmod/, (and rebooted again, just to make sure) -- and now I can kldload i915kms again without problems, and everything works again. So I am now again on the latest 13/stable, and everything works. A big Thank You to Doug and Emmanuel for fixing this, and to Jonathan for reporting it! Jeff On Wed, Dec 21, 2022 at 01:56:31PM +0100, Per olof Ljungmark wrote: > I am facing the same issue as in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268492 > or possibly > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267421 > with a T490 laptop. > > Can someone please help with the git command to fetch an earlier > version, for example the one for the amd64 December 9th. snapshot? > > Instead of > git clone -b stable/13 --depth 1 https://git.freebsd.org/src.git /usr/src > > (this of course if the issue is not already fixed with current 13-STABLE) > > Thanks, > Per