Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Jun 2021 00:40:17 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 71622a3518c4 - stable/13 - tmpfs: drop useless parent locking from tmpfs_dir_getdotdotdent
Message-ID:  <202106070040.1570eHU5065339@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=71622a3518c4350140ec4c19326e4ed9288b1092

commit 71622a3518c4350140ec4c19326e4ed9288b1092
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-05-29 15:38:21 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-06-07 00:34:57 +0000

    tmpfs: drop useless parent locking from tmpfs_dir_getdotdotdent
    
    The id field is immutable until the node gets freed.
    
    (cherry picked from commit 7fbeaf33b8e1a5e69af42a77c78a6fcb3029f1ca)
---
 sys/fs/tmpfs/tmpfs_subr.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c
index 8b75c58d69a2..df5bc12047be 100644
--- a/sys/fs/tmpfs/tmpfs_subr.c
+++ b/sys/fs/tmpfs/tmpfs_subr.c
@@ -1436,10 +1436,7 @@ tmpfs_dir_getdotdotdent(struct tmpfs_mount *tm, struct tmpfs_node *node,
 	if (parent == NULL)
 		return (ENOENT);
 
-	TMPFS_NODE_LOCK(parent);
 	dent.d_fileno = parent->tn_id;
-	TMPFS_NODE_UNLOCK(parent);
-
 	dent.d_off = next;
 	dent.d_type = DT_DIR;
 	dent.d_namlen = 2;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202106070040.1570eHU5065339>