Date: Tue, 12 Feb 2013 10:53:51 +0400 From: Dmitry Sivachenko <trtrmitya@gmail.com> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Alexander Leidinger <netchild@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r312035 - head/audio/lame Message-ID: <C40B978F-AC8B-42ED-8E6F-1E828A872F85@FreeBSD.org> In-Reply-To: <CAF6rxg=n8C_pbegUHOs4J40RPQftEfnOKjYNiwSw_EbHevu%2B1Q@mail.gmail.com> References: <201302101723.r1AHNtaU044891@svn.freebsd.org> <20130212050358.GA89487@FreeBSD.org> <CAF6rxg=n8C_pbegUHOs4J40RPQftEfnOKjYNiwSw_EbHevu%2B1Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12.02.2013, at 9:52, Eitan Adler <eadler@FreeBSD.org> wrote: > On 12 February 2013 00:03, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> On Sun, Feb 10, 2013 at 05:23:55PM +0000, Alexander Leidinger wrote: >>> New Revision: 312035 >>> URL: http://svnweb.freebsd.org/changeset/ports/312035 >>>=20 >>> Log: >>> Add dependency to libiconv. >>=20 >> :) I would say adding USE_ICONV is probably useless in cases like = this one, >> when it's getting pulled via other stuff. >=20 > If a port directly uses ICONV it must explicitly depend on it, and > must not rely on indirect dependencies. >=20 > As for a PORTREVISION bump, this is more interesting: I am inclined > to bump because the "manifest" of the port changed. There is nothing interesting here, you should definitely reread section = 5.2.2.1 of Porter's handbook: = http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile= -naming.html#makefile-naming-revepoch
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C40B978F-AC8B-42ED-8E6F-1E828A872F85>