Date: Thu, 14 Sep 2000 13:42:59 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Peter Wemm <peter@netplex.com.au> Cc: Gregory Neil Shapiro <gshapiro@gshapiro.net>, "Steven E. Ames" <steve@virtual-voodoo.com>, Gregory Neil Shapiro <gshapiro@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sendmail Makefile Message-ID: <Pine.BSF.4.21.0009141331410.390-100000@besplex.bde.org> In-Reply-To: <200009131756.e8DHutG95016@netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 13 Sep 2000, Peter Wemm wrote:
> Gregory Neil Shapiro wrote:
> > steve> Am I missing something obvious? How do I add libraries (e.g. Cyrus SAS
> L)
> > steve> without modifying this Makefile (which is what I normally do)... I'm
> > steve> maybe not seeing or understanding the hooks?
> >
> > Add this to /etc/make.conf:
> >
> > .if ${.CURDIR} == "/usr/src/usr.sbin/sendmail"
> > CFLAGS+=-DSASL -I/usr/local/include/sasl
> > LDADD+=-L/usr/local/lib -lsasl
> > .endif
>
> Oh my, this is scarey. :-)
This is just bogus :-). LDADD is not user servicable. Apart from
conventional reasons, the library order may be important, and a
single variable doesn't provide enough control.
Setting LDADD without setting DPADD breaks dependencies. Use
`make checkdpadd' to check that DPADD is consistent with LDADD.
`make checkdpadd' doesn't understand -L in LDADD, so you have to
use the full path to nonstandard libraries (static version) to
quiet it. Authors of /etc/make.conf shouldn't have to know
these details.
> May I suggest something like this instead?
>
> Add SASL_PREFIX=/usr/local to /etc/make.conf
>
> and in the sendmail Makefile:
>
> .if defined(SASL_PREFIX)
> CFLAGS+= -DSASL -I${SASL_PREFIX}/include/sasl
> LDADD+= -L{$SASL_PREFIX}/lib -lsasl
> .endif
>
> The user exposure is much smaller then. They just have to add the location
> of the SASL stuff.
This is OK except for the missing DPADD, use of -L, and a space instead of
a tab after LDADD+=.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0009141331410.390-100000>