From owner-freebsd-hackers Fri Apr 5 6:31:13 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from freebsd.dk (fw-rl0.freebsd.dk [212.242.86.114]) by hub.freebsd.org (Postfix) with ESMTP id E67C137B404 for ; Fri, 5 Apr 2002 06:31:08 -0800 (PST) Received: (from sos@localhost) by freebsd.dk (8.11.6/8.11.6) id g35EV5b33064; Fri, 5 Apr 2002 16:31:05 +0200 (CEST) (envelope-from sos) From: Søren Schmidt Message-Id: <200204051431.g35EV5b33064@freebsd.dk> Subject: Re: cdcontrol(1) speed command In-Reply-To: To: Philipp Mergenthaler Date: Fri, 5 Apr 2002 16:31:04 +0200 (CEST) Cc: freebsd-hackers@FreeBSD.ORG, maxim@macomnet.ru Reply-To: sos@freebsd.dk X-Mailer: ELM [version 2.4ME+ PL94b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG It seems Philipp Mergenthaler wrote: > > @@ -24,6 +24,7 @@ > > #endif /* not lint */ > > > #include > > +#include > > Jörg Wunsch commented that adding "include " would be > wrong and that this ioctl should be moved to sys/cdio.h instead. > (I guess then it should be renamed to CDIOCREADSPEED, too.) > This would then have to be changed in src/sys/dev/ata/atapi-cd.c, too. Hmm, then the functionality should be added to the SCSI CD driver first, until then its only for ATAPI CDROM's, and should stay where it is, to not break binary compatibility.. -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message