From owner-freebsd-stable@FreeBSD.ORG Fri Jan 18 06:33:26 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 224CD16A4A0; Fri, 18 Jan 2008 06:33:26 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.freebsd.org (Postfix) with ESMTP id 7C6F913C4E8; Fri, 18 Jan 2008 06:33:25 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from inchoate.gsoft.com.au (ppp121-45-39-232.lns10.adl2.internode.on.net [121.45.39.232]) (authenticated bits=0) by cain.gsoft.com.au (8.13.8/8.13.8) with ESMTP id m0I6XMp5011250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Jan 2008 17:03:23 +1030 (CST) (envelope-from doconnor@gsoft.com.au) From: "Daniel O'Connor" To: Peter Jeremy Date: Fri, 18 Jan 2008 17:03:04 +1030 User-Agent: KMail/1.9.7 References: <200801171410.38488.doconnor@gsoft.com.au> <200801180817.49452.doconnor@gsoft.com.au> <20080118055754.GV929@server.vk2pj.dyndns.org> In-Reply-To: <20080118055754.GV929@server.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart21441571.cMrykjZWen"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200801181703.11941.doconnor@gsoft.com.au> X-Spam-Score: -2.386 () AWL,BAYES_00,RDNS_DYNAMIC X-Scanned-By: MIMEDefang 2.63 on 203.31.81.10 Cc: freebsd-stable@freebsd.org, John Baldwin Subject: Re: kldstat causes kernel to print odd message X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2008 06:33:26 -0000 --nextPart21441571.cMrykjZWen Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Fri, 18 Jan 2008, Peter Jeremy wrote: > On Fri, Jan 18, 2008 at 08:17:40AM +1030, Daniel O'Connor wrote: > >On Fri, 18 Jan 2008, John Baldwin wrote: > >> amd64 uses link_elf_obj.c, all the other archs use link_elf.c, > >> hence the duplication. > > Then why does amd64 need link_elf.c at all? I wonder if it's because you can't put !amd64 in sys/conf/files :) (so you'd have to put it in every platform specific files instead) > >I guess one option would be to put #ifdef amd64 around the error > > message in link_elf.c. > > If there's a possibility that multiple ELF linkers could be required > in the future, a cleaner option might be to make link_elf_error() > just cache the error message and only report it after all possible > linkers have refused to load the file. That would be the Right Way(tm).. probably just #ifndef amd64'ing=20 link_elf.c will be easier :) One thing that gets me is why I get this problem but noone else seems=20 to.. =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart21441571.cMrykjZWen Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHkEgn5ZPcIHs/zowRAu3LAJ0bTwEDrWsxJ/eUSjxpMqX7tyQVJwCdEpjX cA3LX+cjqgAZ4UJ1ema/dqk= =9LrA -----END PGP SIGNATURE----- --nextPart21441571.cMrykjZWen--