From owner-freebsd-current@FreeBSD.ORG Wed May 24 19:51:06 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37E3916A4FC for ; Wed, 24 May 2006 19:51:06 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AA7143D45 for ; Wed, 24 May 2006 19:51:02 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4OJoiYH020892; Wed, 24 May 2006 13:50:50 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4474B908.80903@samsco.org> Date: Wed, 24 May 2006 13:50:32 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Gordon Bergling References: <20060524180802.GA59176@central.0xfce3.net> In-Reply-To: <20060524180802.GA59176@central.0xfce3.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: freebsd-current@freebsd.org Subject: Re: Take 2: new IP Checksum Code from DragonFlyBSD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2006 19:51:07 -0000 Gordon Bergling wrote: > Hi, > > a few month ago I ported DragonFlyBSD's IP checksum code to FreeBSD. > My first try wasn't complete and I had forgotten it by the time. Now I > hope I have addressed the former mistakes and it maybe included in the > tree. ;) > > The patch can be found at > http://generic.0xfce3.net/20060524-ipchecksum.patch > > This patch modifies the i386, amd64 and pc98 architectures. Matt Dillons > new implementation is machine indepement, but there are some asm > files/code with seems for me i386 centric. I don't know assembler, so I > can't tell much about it. > > I applied the patch to RELENG_6 and have done a simple netperf > benchmark. The machine was a PIII 900. > > The ministat output: > ---------------------------------------------------------------------------- > x netperf-localhost-plain.txt > + netperf-localhost-ncksum.txt > +--------------------------------------------------------------------------+ > | x x x x + ++ + | > |xx x x xx xxx x x x x+x *+x x + +++ ++ + + + +++++ +| > | |__________M_A____________| |__________A___________| | > +--------------------------------------------------------------------------+ > N Min Max Median Avg Stddev > x 22 707.31 730.41 717.37 718.53909 6.7389076 > + 22 725.57 746.46 736.535 736.51727 6.3001188 > Difference at 95.0% confidence > 17.9782 +/- 3.96904 > 2.50205% +/- 0.552377% > (Student's t, pooled s = 6.5232) > ---------------------------------------------------------------------------- > > Any comments, correctures are very appreciated. > > best regards, > > Gordon > First, it would be nice to know what netstat options you were using. Second, it would be nice to know if hardware checksum offloading was enabled at all on either end of the test. Scott