From nobody Sat Apr 15 16:13:47 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PzJKC0Jkfz45bBh; Sat, 15 Apr 2023 16:13:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PzJKB6Dm3z4Dn4; Sat, 15 Apr 2023 16:13:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id nbnTp7UrxuZMSniX8pWrBU; Sat, 15 Apr 2023 16:13:50 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id niX6pklvc3fOSniX7pk3Xw; Sat, 15 Apr 2023 16:13:50 +0000 X-Authority-Analysis: v=2.4 cv=J8G5USrS c=1 sm=1 tr=0 ts=643acd3e a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dKHAf1wccvYA:10 a=pIhXSETnAAAA:8 a=YxBL1-UpAAAA:8 a=NEAV23lmAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=Paoh2FSOps8af3h1t30A:9 a=CjuIK1q_8ugA:10 a=aStlkcwk48vnf0XRxVrg:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 6B176AEB; Sat, 15 Apr 2023 09:13:48 -0700 (PDT) Received: from localhost (localhost [IPv6:::1]) by slippy.cwsent.com (Postfix) with ESMTP id 2477026F; Sat, 15 Apr 2023 09:13:48 -0700 (PDT) Date: Sat, 15 Apr 2023 09:13:47 -0700 From: Cy Schubert To: Florian Smeets Cc: FreeBSD User , Mark Millard , Charlie Li , Pawel Jakub Dawidek , Mateusz Guzik , dev-commits-src-main@freebsd.org, Current FreeBSD Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <20230415091342.75009659@cschubert.com> In-Reply-To: <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz> References: <20230413071032.18BFF31F@slippy.cwsent.com> <20230413063321.60344b1f@cschubert.com> <20230413135635.6B62F354@slippy.cwsent.com> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> <32cad878-726c-4562-0971-20d5049c28ad@freebsd.org> <20230415115452.08911bb7@thor.intern.walstatt.dynvpn.de> <20230415143625.99388387@slippy.cwsent.com> <20230415175218.777d0a97@thor.intern.walstatt.dynvpn.de> <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz> Organization: KOMQUATS X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfCSL93zqe2hzlbT+rN0mtdsNDcYLe6PAakrNqlaNvC6WGkAjG20z7r/moR5K9lHkrQr6GuPNrLme3GKKTIT4JdqVclocQG3TcUsNYQkAZ05Mtuoucwg7 BRcIF5K8VJFCG2SfpdY7rkRd9qxDNx+kA925eDmCzkFW/TgZO296hG9Y5iF+VRNaiOn6O8k+ATgsENHnOfLCPfCrst/9WkPpCQBZJcIH84xOreqOpHacjoJN xp2VS+huqlD5U5E0UGb+Vm57eYdhBen/WPokplwHg3GTrD4Tg3po/t/6+XnSBIsIohiMQPz7SyeKIlU1/aydMQeFT62Cz4MBNpm2bfv72e8qV1E1hHusbz/B 7wB4iO3qqkpWzk+xzxB82scS7x974yKM5BimwScYLWLGS9IpMTcAyZM+f3oMuiaEkByavSPeQB0VpNXuncVgXMg+CLqcmg== X-Rspamd-Queue-Id: 4PzJKB6Dm3z4Dn4 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, 15 Apr 2023 18:07:34 +0200 Florian Smeets wrote: > On 15.04.23 17:51, FreeBSD User wrote: > > Am Sat, 15 Apr 2023 07:36:25 -0700 > > Cy Schubert schrieb: > >> > >> With an up-to-date tree + pjd@'s "Fix data corruption when cloning embedded > >> blocks. #14739" patch I didn't have any issues, except for email messages > >> with corruption in my sent directory, nowhere else. I'm still investigating > >> the email messages issue. IMO one is generally safe to run poudriere on the > >> latest ZFS with the additional patch. > > This is also my current observation. I have 2 hosts where I was > unfortunate enough to update at the wrong time. I currently *think* that > I'm *not* seeing data corruption with head from April 12th and this > patch > https://github.com/openzfs/zfs/commit/d3a6e5ca3b2f684132238ca968bf0b96f17ec7e1.diff > applied. > > One pool has been upgraded with feature@block_cloning and the other hasn't. > > > > FreeBSD 14.0-CURRENT #8 main-n262175-5ee1c90e50ce: Sat Apr 15 07:57:16 CEST 2023 amd64 > > > > The box is crashing while trying to update ports with the well known issue: > > > > Panic String: VERIFY(!zil_replaying(zilog, tx)) failed > > > On the pool that has block_cloning enabled I see the above insta panic > when poudriere starts building. I found a workaround though: > > --- /usr/local/share/poudriere/include/fs.sh.orig 2023-04-15 > 18:03:50.090823000 +0200 > +++ /usr/local/share/poudriere/include/fs.sh 2023-04-15 > 18:04:04.144736000 +0200 > @@ -295,7 +295,6 @@ > fi > > zfs clone -o mountpoint=${mnt} \ > - -o sync=disabled \ > -o atime=off \ > -o compression=off \ > ${fs}@${snap} \ > > With this workaround I was able to build thousands of packages without > panics or failures due to data corruption. Thanks for this. I'll test this next week. A one should be able to test this by hand to capture a dump. > > Florian -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0