Date: Sat, 15 Apr 2023 09:13:47 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Florian Smeets <flo@smeets.xyz> Cc: FreeBSD User <freebsd@walstatt-de.de>, Mark Millard <marklmi@yahoo.com>, Charlie Li <vishwin@freebsd.org>, Pawel Jakub Dawidek <pjd@FreeBSD.org>, Mateusz Guzik <mjguzik@gmail.com>, dev-commits-src-main@freebsd.org, Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <20230415091342.75009659@cschubert.com> In-Reply-To: <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz> References: <20230413071032.18BFF31F@slippy.cwsent.com> <D0D9BD06-C321-454C-A038-C55C63E0DD6B@dawidek.net> <20230413063321.60344b1f@cschubert.com> <CAGudoHG3rCx93gyJTmzTBnSe4fQ9=m4mBESWbKVWtAGRxen_4w@mail.gmail.com> <20230413135635.6B62F354@slippy.cwsent.com> <c41f9ed6-e557-9255-5a46-1a22d4b32d66@dawidek.net> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <b60807e9-f393-6e6d-3336-042652ddd03c@freebsd.org> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> <32cad878-726c-4562-0971-20d5049c28ad@freebsd.org> <ABC9F3DB-289E-455E-AF43-B3C13525CB2C@yahoo.com> <20230415115452.08911bb7@thor.intern.walstatt.dynvpn.de> <20230415143625.99388387@slippy.cwsent.com> <20230415175218.777d0a97@thor.intern.walstatt.dynvpn.de> <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Apr 2023 18:07:34 +0200 Florian Smeets <flo@smeets.xyz> wrote: > On 15.04.23 17:51, FreeBSD User wrote: > > Am Sat, 15 Apr 2023 07:36:25 -0700 > > Cy Schubert <Cy.Schubert@cschubert.com> schrieb: > >> > >> With an up-to-date tree + pjd@'s "Fix data corruption when cloning embedded > >> blocks. #14739" patch I didn't have any issues, except for email messages > >> with corruption in my sent directory, nowhere else. I'm still investigating > >> the email messages issue. IMO one is generally safe to run poudriere on the > >> latest ZFS with the additional patch. > > This is also my current observation. I have 2 hosts where I was > unfortunate enough to update at the wrong time. I currently *think* that > I'm *not* seeing data corruption with head from April 12th and this > patch > https://github.com/openzfs/zfs/commit/d3a6e5ca3b2f684132238ca968bf0b96f17ec7e1.diff > applied. > > One pool has been upgraded with feature@block_cloning and the other hasn't. > > > > FreeBSD 14.0-CURRENT #8 main-n262175-5ee1c90e50ce: Sat Apr 15 07:57:16 CEST 2023 amd64 > > > > The box is crashing while trying to update ports with the well known issue: > > > > Panic String: VERIFY(!zil_replaying(zilog, tx)) failed > > > On the pool that has block_cloning enabled I see the above insta panic > when poudriere starts building. I found a workaround though: > > --- /usr/local/share/poudriere/include/fs.sh.orig 2023-04-15 > 18:03:50.090823000 +0200 > +++ /usr/local/share/poudriere/include/fs.sh 2023-04-15 > 18:04:04.144736000 +0200 > @@ -295,7 +295,6 @@ > fi > > zfs clone -o mountpoint=${mnt} \ > - -o sync=disabled \ > -o atime=off \ > -o compression=off \ > ${fs}@${snap} \ > > With this workaround I was able to build thousands of packages without > panics or failures due to data corruption. Thanks for this. I'll test this next week. A one should be able to test this by hand to capture a dump. > > Florian -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230415091342.75009659>