From nobody Tue May 24 15:27:09 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 98BFB1B4CB12 for ; Tue, 24 May 2022 15:27:20 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L6yjz5w4Tz4qGd; Tue, 24 May 2022 15:27:19 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 692B08D4A173; Tue, 24 May 2022 15:27:12 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E8359E7085E; Tue, 24 May 2022 15:27:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id qwzISj6R3TbQ; Tue, 24 May 2022 15:27:09 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id C5D23E7085A; Tue, 24 May 2022 15:27:09 +0000 (UTC) Date: Tue, 24 May 2022 15:27:09 +0000 (UTC) From: "Bjoern A. Zeeb" To: Stefan Esser cc: freebsd-ports@freebsd.org Subject: Re: NO_TEST, do-test: and TEST_DEPENDS? In-Reply-To: <848ba292-d306-dcd7-2456-383f1a3652f6@FreeBSD.org> Message-ID: References: <848ba292-d306-dcd7-2456-383f1a3652f6@FreeBSD.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-405137535-1653406029=:68830" X-Rspamd-Queue-Id: 4L6yjz5w4Tz4qGd X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2a01:4f8:13b:39f::9f:25 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net X-Spamd-Result: default: False [-1.30 / 15.00]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:13b:39f::9f:25]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; DMARC_NA(0.00)[zabbadoz.net]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; CTYPE_MIXED_BOGUS(1.00)[]; RCPT_COUNT_TWO(0.00)[2]; MLMMJ_DEST(0.00)[freebsd-ports]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; SUBJECT_ENDS_QUESTION(1.00)[] X-ThisMailContainsUnwantedMimeParts: N This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-405137535-1653406029=:68830 Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 22 May 2022, Stefan Esser wrote: > I'm not sure I understand the goal of your request. the goal is to cut down dependencies and build time. > Do you want to have a switch that prevents the execution of tests when > "make test" explicitly asks for the tests to be run??? > > This could easily be added to bsd.port.mk, but what for??? > >> What is the proper way to >>     (1) disable tests > > That's what I do not understand ... Tests are not run by default, and > thus I never saw the need to disable them in any of my ports. > > Quite the opposite: If "make test" is invoked for a port that supports > tests, I definitely want them to be executed. Right, so maybe solving (2) will solve (1) implicitly as I probably don't have to disable them then using .ifdef bits. >> and more important >>     (2) to amke sure the TEST_DEPENDS and not build in these cases? > > You can set "DO_MAKE_TEST=true" to execute the command "true" instead > of "make" when bsd.port.mk wants to execute the tests. > > But this is an undocumented internal variable of the ports system, and > it could be removed or renamed at any time, when changes are applied > to bsd.port.mk. > > And you could override the TEST_DEPENDS macro instead of wrapping it > into an .if block. how? putting .if defined(TEST_DEPENDS) .undef TEST_DEPENDS .endif or something like that in make.conf? >> While I can iterate on port after port and apply a change like the below it >> feels utterly wrong and it seems I am doing something silly here which has a >> proper knob I cannot find? > > Please explain what you want to achieve. There may be other ways to > achieve your goal, but I think I do not understand what your goal is ... Okay, for I have no idea anymore how long I've built the ports I need in the classical way; I have a "meta port" depending on the 25 packages I need to build. The problem has bcome that rather than simple builds the amounts of ports build exploded. With that the addition of conflicts has also exploded. something people do probably not see (anymore these days) if their build depends conflict. One larger contributor to the explosion is TEST_DEPENDS. I'll give you an example. cd dns/bind9 && env BATCH=yes NO_TEST= make all-depends-list Feel free to disable DNSTAP DOCS and MANPAGES (manually) to avoid python for any of that (but there are different stories for another time). Crazy, right? It comes from TEST_DEPENDS mostly. I still haven't all tracked down which include stuff which is never even used. Sorry, the world is warm enough.. did we stop thinking again? /bz -- Bjoern A. Zeeb r15:7 --0-405137535-1653406029=:68830--