Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 May 1999 08:52:18 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, peter@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/en midway.c
Message-ID:  <199905062252.IAA25539@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Modified files:
>    sys/dev/en           midway.c 
>  Log:
>  Undo excess staticization - these two are meant to be callable from
>  DDB.

This is bogus.  ddb has no problems calling static function (except for
some cases with elf kernels).  If you don't like the -Wunused warning,
then add the function to the ddb command table so that it is used.

Related bogons:
- these functions are compiled even when ddb is not configured.
- midway.c has a debugger hook which is only compiled if EN_DEBUG and DDB
  are defined, but DDB is never defined since opt_ddb.h is not included,
  and the hook wouldn't actually work if EN_DEBUG and DDB were defined,
  since it calls Debugger() with the wrong number of args.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199905062252.IAA25539>