Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Nov 2013 19:25:24 +0100
From:      John Marino <freebsd.contact@marino.st>
To:        "Jason E. Hale" <jhale@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r332099 - head/devel/cssc/files
Message-ID:  <5273F214.3040406@marino.st>
In-Reply-To: <5558324.uLoFuByiHu@mocha.verizon.net>
References:  <201310301246.r9UCkiWu069471@svn.freebsd.org> <5271A160.8050309@marino.st> <5272FBC0.2050306@marino.st> <5558324.uLoFuByiHu@mocha.verizon.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/1/2013 18:55, Jason E. Hale wrote:
> On Friday, November 01, 2013 01:54:24 John Marino wrote:
>>
>> Well, the maintainer patch does NOT contain <unistd.h>, contrary to what
>> you said earlier so now it's broken again with gcc47+.
>>
>> Can you please retrieve the contents of my patch and integrate it into
>> the maintainer patch?
>>
> I'm not sure why it would break.  The following is in the patched file:
> 
> #elif defined(__FreeBSD__)
> #define GTEST_OS_FREEBSD 1
> #define GTEST_USE_OWN_TR1_TUPLE 1
> #endif  // __CYGWIN__
> 
> #if GTEST_OS_CYGWIN || GTEST_OS_LINUX || GTEST_OS_MAC || GTEST_OS_SYMBIAN || \
>     GTEST_OS_SOLARIS || GTEST_OS_AIX || GTEST_OS_FREEBSD
> 

Well, because __FreeBSD__ isn't defined on DragonFly.  The first line
needs to append "|| defined(__DragonFly__)" in order to define
GTEST_OS_FREEBSD to include those headers.

Thanks - sorry I didn't look at the file in its entirety, only the patch.
John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5273F214.3040406>