From owner-freebsd-current Sun Oct 20 14: 9:33 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66E1237B404; Sun, 20 Oct 2002 14:09:32 -0700 (PDT) Received: from carp.icir.org (carp.icir.org [192.150.187.71]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEA3543E42; Sun, 20 Oct 2002 14:09:31 -0700 (PDT) (envelope-from rizzo@carp.icir.org) Received: from carp.icir.org (localhost [127.0.0.1]) by carp.icir.org (8.12.3/8.12.3) with ESMTP id g9KL9VpJ008389; Sun, 20 Oct 2002 14:09:31 -0700 (PDT) (envelope-from rizzo@carp.icir.org) Received: (from rizzo@localhost) by carp.icir.org (8.12.3/8.12.3/Submit) id g9KL9VRf008388; Sun, 20 Oct 2002 14:09:31 -0700 (PDT) (envelope-from rizzo) Date: Sun, 20 Oct 2002 14:09:31 -0700 From: Luigi Rizzo To: current@freebsd.org Subject: minor bug in MAKEDEV ? Message-ID: <20021020140931.A8360@carp.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [Bcc re@ in case i need to commit a fix] i think the snippet of code below (from etc/MAKEDEV) should not use $unit, because the goal is to create a /dev/usb entry. It works now because it normally happens to be called with $unit unset, but this is not always the case. Same bug is also in -stable. 1.220 (n_hibma 17-Nov-99): usb) 1.237 (n_hibma 21-Jan-00): mknod usb$unit c 108 255 root:operator 1.237 (n_hibma 21-Jan-00): chmod 0660 usb$unit 1.179 (n_hibma 03-Jan-99): ;; Should i commit the [trivial] fix which is remove $unit from both lines ? cheers luigi ----------------------------------+----------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . ICSI (on leave from Univ. di Pisa) http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 Phone: (510) 666 2988 ----------------------------------+----------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message