From owner-cvs-src@FreeBSD.ORG Thu Mar 24 15:08:39 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33DE416A4CE; Thu, 24 Mar 2005 15:08:39 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 448C743D2F; Thu, 24 Mar 2005 15:08:38 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.3/8.13.1) with ESMTP id j2OF5xd0056164; Thu, 24 Mar 2005 08:05:59 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 24 Mar 2005 08:06:29 -0700 (MST) Message-Id: <20050324.080629.36604178.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <4241E29C.7010407@root.org> References: <1111611460.1805.1.camel@localhost> <20050323.143742.74706153.imp@bsdimp.com> <4241E29C.7010407@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: vova@fbsd.ru cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/acpica acpi_perf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2005 15:08:39 -0000 In message: <4241E29C.7010407@root.org> Nate Lawson writes: : Warner Losh wrote: : >>>Ok, I've committed a fix: acpi.c rev 1.207. Please cvsup and test. : >> : >>It does not help, still same panic : > : > : > It doesn't help me either, and an audit of the code suggests that it : > will have no effect. There's a resource that's marked as being : > active, which is why the panic is happening.... I've always hated : > these panics, but have appreciated them in hindsight once the bug has : > been fixed because it is a very effective enforcement of proper : > operations. : > : > Warner : : I'm trying to figure out what's going on. The probe routine should not : be called multiple times since it returns 0 and now with my commit it : should completely clean up after itself. Can you put this in : acpi_perf_identify, probe, attach and let me know the full dmesg up to : the panic? I'll give it a try. I'll reiterate that probe routines should do nothing more than 'I'm here' and all other processing should be done in attach. It looks like that might be a little hard in this case, but I've not looked into it in detail. Warner