Date: Mon, 2 Jan 2012 01:38:36 -0500 From: Ben Kaduk <minimarmot@gmail.com> To: Glen Barber <gjb@freebsd.org> Cc: svn-src-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, Ulrich Spoerlein <uqs@freebsd.org> Subject: Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp... Message-ID: <CAK2BMK6r4GD1%2B1fGM%2B2Q-ZZa-jbgWGHd02eg6WhBw9OKWjmkYw@mail.gmail.com> In-Reply-To: <20111230200405.GA293@glenbarber.us> References: <201112301058.pBUAwFsw010478@svn.freebsd.org> <CAK2BMK6p3VJXezt%2Bpa7-0MbP4=Uv79i=D=cxmDrpAwUK2Mw2vQ@mail.gmail.com> <20111230195444.GA25204@FreeBSD.org> <20111230200405.GA293@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 30, 2011 at 3:04 PM, Glen Barber <gjb@freebsd.org> wrote: > On Fri, Dec 30, 2011 at 07:54:44PM +0000, Alexey Dokuchaev wrote: >> On Fri, Dec 30, 2011 at 02:43:22PM -0500, Ben Kaduk wrote: >> > On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein <uqs@freebsd.org> wr= ote: >> > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* is 11 bit wide that gives us upto= 2048 chunks. >> > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* is 11 bit wide that gives us up t= o 2048 chunks. >> > >> > Should be "11 bits", no? >> >> I'm not a native speaker, but I think "11 bit wide" is correct here. =A0= I >> could have probably got into specifics, but simple googling for "16 ton = shit >> dropped on me" yielded 525M results, while the same phrase with "tons" o= nly >> 18,9M. =A0:-^ >> > > Considering the full context, maybe it would be better written as: > > rsp_cs is an 11 bit wide field that gives ... (I'm a native speaker, too.) Were I to seriously wordsmith the comment, I would make it: * The minimum L2CAP MTU is 43 bytes. That means we need * ceiling(65536 / 43) =3D 1525 chunks to transfer the maximum * packet size with minimum MTU. Since the "rsp_cs" field in * fd_idx_t is 11 bits wide, that allows up to 2048 chunks which * is more than sufficient. But it may not be worth worrying about it this much. -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK2BMK6r4GD1%2B1fGM%2B2Q-ZZa-jbgWGHd02eg6WhBw9OKWjmkYw>