From owner-svn-src-all@FreeBSD.ORG Mon Jan 2 06:38:38 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40EEF1065688; Mon, 2 Jan 2012 06:38:38 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id A6AB98FC13; Mon, 2 Jan 2012 06:38:37 +0000 (UTC) Received: by ghrr16 with SMTP id r16so6244918ghr.13 for ; Sun, 01 Jan 2012 22:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=R30geHAIyD45NTBNn6c4YOJSSIF2BxJNw98BGnIpd4g=; b=UEH9zEX5CHaAn8BdngrsapGuXxt8MRWzFlsLtCGARj7O0Z1jV7riFQ4xYXwnyeTLKB NrMqeTzCI1X98XVaLbcyMRbBA1QKLNPWg/ZzM3v+l/aP4G3XSdr80339eBH3pecDWjFU E77mElikrWbFw9fz9HuiuoEki1BupHcNjZjR4= MIME-Version: 1.0 Received: by 10.236.173.40 with SMTP id u28mr15218081yhl.15.1325486316971; Sun, 01 Jan 2012 22:38:36 -0800 (PST) Received: by 10.236.110.40 with HTTP; Sun, 1 Jan 2012 22:38:36 -0800 (PST) In-Reply-To: <20111230200405.GA293@glenbarber.us> References: <201112301058.pBUAwFsw010478@svn.freebsd.org> <20111230195444.GA25204@FreeBSD.org> <20111230200405.GA293@glenbarber.us> Date: Mon, 2 Jan 2012 01:38:36 -0500 Message-ID: From: Ben Kaduk To: Glen Barber Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, Ulrich Spoerlein Subject: Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 06:38:38 -0000 On Fri, Dec 30, 2011 at 3:04 PM, Glen Barber wrote: > On Fri, Dec 30, 2011 at 07:54:44PM +0000, Alexey Dokuchaev wrote: >> On Fri, Dec 30, 2011 at 02:43:22PM -0500, Ben Kaduk wrote: >> > On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein wr= ote: >> > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* is 11 bit wide that gives us upto= 2048 chunks. >> > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* is 11 bit wide that gives us up t= o 2048 chunks. >> > >> > Should be "11 bits", no? >> >> I'm not a native speaker, but I think "11 bit wide" is correct here. =A0= I >> could have probably got into specifics, but simple googling for "16 ton = shit >> dropped on me" yielded 525M results, while the same phrase with "tons" o= nly >> 18,9M. =A0:-^ >> > > Considering the full context, maybe it would be better written as: > > rsp_cs is an 11 bit wide field that gives ... (I'm a native speaker, too.) Were I to seriously wordsmith the comment, I would make it: * The minimum L2CAP MTU is 43 bytes. That means we need * ceiling(65536 / 43) =3D 1525 chunks to transfer the maximum * packet size with minimum MTU. Since the "rsp_cs" field in * fd_idx_t is 11 bits wide, that allows up to 2048 chunks which * is more than sufficient. But it may not be worth worrying about it this much. -Ben