From owner-freebsd-xen@FreeBSD.ORG Tue Jan 21 19:03:20 2014 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 761D1486; Tue, 21 Jan 2014 19:03:20 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4A7FF1E13; Tue, 21 Jan 2014 19:03:20 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B3974B945; Tue, 21 Jan 2014 14:03:18 -0500 (EST) From: John Baldwin To: Roger Pau Monne Subject: Re: [PATCH RFC 04/13] xen: implement basic PIRQ support for Dom0 Date: Tue, 21 Jan 2014 13:52:44 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com> <1387884062-41154-5-git-send-email-roger.pau@citrix.com> In-Reply-To: <1387884062-41154-5-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201401211352.44784.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 21 Jan 2014 14:03:19 -0500 (EST) Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org, gibbs@freebsd.org X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 19:03:20 -0000 On Tuesday, December 24, 2013 6:20:53 am Roger Pau Monne wrote: > This allows Dom0 to manage physical hardware, redirecting the > physical interrupts to event channels. > --- > sys/x86/xen/xen_intr.c | 190 +++++++++++++++++++++++++++++++++++++++++++++-- > sys/xen/xen_intr.h | 11 +++ > 2 files changed, 192 insertions(+), 9 deletions(-) > > diff --git a/sys/x86/xen/xen_intr.c b/sys/x86/xen/xen_intr.c > index bc0781e..340e5ed 100644 > --- a/sys/x86/xen/xen_intr.c > +++ b/sys/x86/xen/xen_intr.c > @@ -104,6 +104,8 @@ DPCPU_DECLARE(struct vcpu_info *, vcpu_info); > > #define is_valid_evtchn(x) ((x) != 0) > > +#define EEXIST 17 /* Xen "already exists" error */ Is there a xen_errno.h header? Might be nice to have one and give these constants unique names (e.g. XEN_EEXIST or some such) to avoid confusion/conflicts with . Other than that I think this looks fine. -- John Baldwin