From owner-dev-commits-src-all@freebsd.org Tue Aug 3 10:11:15 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 96888635A96; Tue, 3 Aug 2021 10:11:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gf9cz3pFkz3QZQ; Tue, 3 Aug 2021 10:11:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6BE811191F; Tue, 3 Aug 2021 10:11:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 173ABFE7005489; Tue, 3 Aug 2021 10:11:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 173ABF3N005488; Tue, 3 Aug 2021 10:11:15 GMT (envelope-from git) Date: Tue, 3 Aug 2021 10:11:15 GMT Message-Id: <202108031011.173ABF3N005488@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 29b4fa787621 - main - hdaa: add missing break in hdac_pin_patch(). MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 29b4fa787621cbfb070323ecf2ea2da4d372bd94 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 10:11:15 -0000 The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=29b4fa787621cbfb070323ecf2ea2da4d372bd94 commit 29b4fa787621cbfb070323ecf2ea2da4d372bd94 Author: Gleb Smirnoff AuthorDate: 2021-08-03 10:06:16 +0000 Commit: Gleb Smirnoff CommitDate: 2021-08-03 10:09:32 +0000 hdaa: add missing break in hdac_pin_patch(). Fixes driver attach on my Thinkpad X1 Carbon, and likely on many other ALC family devices. Fixes: ef790cc7407e827db9563d08a52a71ab36436986 --- sys/dev/sound/pci/hda/hdaa_patches.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/sound/pci/hda/hdaa_patches.c b/sys/dev/sound/pci/hda/hdaa_patches.c index dc404b9ba98e..45577819e897 100644 --- a/sys/dev/sound/pci/hda/hdaa_patches.c +++ b/sys/dev/sound/pci/hda/hdaa_patches.c @@ -326,6 +326,7 @@ hdac_pin_patch(struct hdaa_widget *w) switch (patch->type) { case PIN_PATCH_TYPE_STRING: patch_str = patch->patch.string; + break; case PIN_PATCH_TYPE_MASK: config &= ~patch->patch.mask[0]; config |= patch->patch.mask[1];