From owner-freebsd-current Tue Feb 25 7:46:58 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08EA037B406; Tue, 25 Feb 2003 07:46:57 -0800 (PST) Received: from h00609772adf0.ne.client2.attbi.com (h00609772adf0.ne.client2.attbi.com [24.61.43.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFD4043F85; Tue, 25 Feb 2003 07:46:53 -0800 (PST) (envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com) Received: from h00609772adf0.ne.client2.attbi.com (localhost.ne.attbi.com [127.0.0.1]) by h00609772adf0.ne.client2.attbi.com (8.12.7/8.12.7) with ESMTP id h1PFluUE009409; Tue, 25 Feb 2003 10:47:56 -0500 (EST) (envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com) Received: (from rodrigc@localhost) by h00609772adf0.ne.client2.attbi.com (8.12.7/8.12.7/Submit) id h1PFluYH009408; Tue, 25 Feb 2003 10:47:56 -0500 (EST) Date: Tue, 25 Feb 2003 10:47:55 -0500 From: Craig Rodrigues To: "Jacques A. Vidrine" Cc: markm@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: OpenSSL should define OPENSSL_THREADS? Message-ID: <20030225154755.GA9400@attbi.com> References: <20030225025821.GA4399@attbi.com> <20030225132209.GB95282@madman.celabo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030225132209.GB95282@madman.celabo.org> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Feb 25, 2003 at 07:22:09AM -0600, Jacques A. Vidrine wrote: > On Mon, Feb 24, 2003 at 09:58:21PM -0500, Craig Rodrigues wrote: > > Hi, > > > > I ran a cvsup of -CURRENT a few days ago. > > > > I have some code which assumes that OPENSSL_THREADS is defined if > > the OpenSSL version is greater than 0.9.7: > > Should the OpenSSL in FreeBSD be defining OPENSSL_THREADS? > > I think you may be right. OpenSSL 0.9.7's out-of-the box configure > creates an opensslconf.h that would define OPENSSL_THREADS on FreeBSD. > > Mark supplied the opensslconf.h's that are used in the FreeBSD build ... > let's see if this is intentional or not. [cc'd] These kind of macro changes can break backwards compatibility (OpenSSL's fault). If the intent is to minimize breakage of ports and such, I would not be opposed to do something like: #define OPENSSL_THREADS 1 #define THREADS OPENSSL_THREADS /** deprecated */ Would this work? -- Craig Rodrigues http://home.attbi.com/~rodrigc rodrigc@attbi.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message