From owner-freebsd-fs Mon Mar 19 22: 1:20 2001 Delivered-To: freebsd-fs@freebsd.org Received: from peorth.iteration.net (peorth.iteration.net [208.190.180.178]) by hub.freebsd.org (Postfix) with ESMTP id 4A48537B718; Mon, 19 Mar 2001 22:01:12 -0800 (PST) (envelope-from keichii@peorth.iteration.net) Received: by peorth.iteration.net (Postfix, from userid 1001) id CD97259283; Tue, 20 Mar 2001 00:00:06 -0600 (CST) Date: Tue, 20 Mar 2001 00:00:06 -0600 From: "Michael C . Wu" To: Robert Watson Cc: freebsd-fs@FreeBSD.org, mckusick@FreeBSD.org, jedgar@FreeBSD.org Subject: Re: First round review request, ACLs for UFS commit Message-ID: <20010320000006.C43637@peorth.iteration.net> Reply-To: "Michael C . Wu" Mail-Followup-To: "Michael C . Wu" , Robert Watson , freebsd-fs@FreeBSD.org, mckusick@FreeBSD.org, jedgar@FreeBSD.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from rwatson@FreeBSD.org on Tue, Mar 20, 2001 at 12:10:57AM -0500 X-PGP-Fingerprint: 5025 F691 F943 8128 48A8 5025 77CE 29C5 8FA1 2E20 X-PGP-Key-ID: 0x8FA12E20 Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, Mar 20, 2001 at 12:10:57AM -0500, Robert Watson scribbled: | For the past few months, we (Chris Faulhaber and myself) have been Great work guys! I think the code that you guys produces is very well written and commented. :) Now I know why there are so few responses to your request for reviews. Your (pl.) code is impeccable. | The most recent revision of the ACL code is 0.6.1, available for download | http://www.TrustedBSD.org/downloads/ Just a small question after reading the latest patch. You don't seem to handle the case where the user forgets that he is not mounting a ACL'ed filesystem and expecting ACL's to work. There seems to be a default fallback to old behavior. Is this necessarily good? i.e. Should we have a default set of ACL's instead? Secondly, how does this affect the performance of the filesystem? Also, there are no man pages that I see. -- +-----------------------------------------------------------+ | keichii@iteration.net | keichii@freebsd.org | | http://iteration.net/~keichii | Yes, BSD is a conspiracy. | +-----------------------------------------------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message