From owner-svn-src-head@freebsd.org Wed Apr 26 22:15:46 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9B5DD512C1; Wed, 26 Apr 2017 22:15:46 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id A27B43DF; Wed, 26 Apr 2017 22:15:46 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au [122.106.153.191]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 768A53C575E; Thu, 27 Apr 2017 08:15:38 +1000 (AEST) Date: Thu, 27 Apr 2017 08:15:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: John Baldwin cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317446 - in head: . share/man/man4 sys/conf sys/dev/cy In-Reply-To: <201704261823.v3QIN9JT004384@repo.freebsd.org> Message-ID: <20170427072027.W3724@besplex.bde.org> References: <201704261823.v3QIN9JT004384@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=KeqiiUQD c=1 sm=1 tr=0 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=6I5d2MoRAAAA:8 a=aTlrREBF24WYHQnKZIIA:9 a=CjuIK1q_8ugA:10 a=_bBvcJC8wCc67rcU61zu:22 a=IjZwj45LgO3ly-622nXo:22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 22:15:47 -0000 On Wed, 26 Apr 2017, John Baldwin wrote: > Log: > Remove the cy(4) driver for Cyclades serial adapters. > > This driver has been disconnected from the build since the new tty > layer was introduced in 8.0 and was never updated for new tty. Please back this out. I asked you not to remove this. It is updated in my tree, and I discussed this and sent you some patches a couple of years ago: XX From bde@optusnet.com.au Sat Oct 18 19:49:40 2014 +1100 XX Date: Sat, 18 Oct 2014 19:49:36 +1100 (EST) XX From: Bruce Evans XX X-X-Sender: bde@besplex.bde.org XX To: Bruce Evans XX cc: John Baldwin XX Subject: patch #1 for old tty bugs (was: Re: Removing disconnected tty drivers) Patches 2-999 are sort of queued behind this. I started committing again, but these are behind other things in my queue. Patch sizes for tty drivers: 754 2658 19842 cy.c.dif 1072 3817 27687 sio.c.dif 50 177 1158 sio_isa.c.dif 22 68 562 sio_puc.c.dif 714 4249 25211 tree1/tty.c.dif 13 71 548 tree1/tty.h.dif 297 1306 8272 tree1/tty_ttydisc.c.dif 26 68 649 tree1/ttydevsw.h.dif 33 91 822 tree1/ttydisc.h.dif 100 577 3709 tree1/uart_tty.c.dif tree1/... [some small patches not shown] [~10% overlap between tree1 and tree2] 1134 4457 28995 tree2/tty.c.dif 49 302 2099 tree2/tty.h.dif 90 318 2272 tree2/tty_ttydisc.c.dif Not as large as I remembered. Updating to use the new tty driver takes (per driver) about 50 lines for locking, 200 lines for interface renaming, and many hundreds of lines to work around bugs. The bug fixes in tty* are mostly independent (except for partial fixes for flow control) and not needed for the drivers to work as well as other drivers. uart is not updated as completely as the other drivers, but just has a couple of fixes to allow it to pass some POSIX tests. Bruce