From owner-svn-ports-head@freebsd.org Fri Jun 19 07:25:02 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 473F334247E; Fri, 19 Jun 2020 07:25:02 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49p9LP1p7Tz3RNs; Fri, 19 Jun 2020 07:25:01 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-ua1-f44.google.com with SMTP id v25so2858247uau.4; Fri, 19 Jun 2020 00:25:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1tyrO0HMaP4KAdMAnWy0NS2wCVMDq5vsDudkgLjeaMI=; b=mfPT9TBzLFccF9686pB+E2PRXt+HLwfOEE3Q1QkCHyrX4VvLhLFUkmSVR7b5oEo4fg 4gLP8zVc1Uho+qX3lZv+MAdpxd3zWGVwAFdbU5Ya3EP4SFk3ZTtbPDGscouc898X0ZL+ 9HTEMOmzJS62ZW5L6tJj7Nlb7huFah/ERo5I+Y0PzM0dX2boIQ9/c1FTqcQjEC7e3Dq4 JIEjw/UbllCA+ttv9y99JuD4SK/KeCiRzhIJRFWDUuISYc5ETuutR+b5j0Ajn6DyId3G qOCk1bufC93aJeZzqkDXuQjvgwRUQWSA68N8w48x5JYTwYExMUGfaQYPRwB2AGw1DXGU N0Yw== X-Gm-Message-State: AOAM532O0mNItMVah8PNdQloWAlN8pa3rvZWb+Zmvgq7epvfLlQi4DXd W8F/UsZZxJd0Npdld1Kzu3oulrAaLck= X-Google-Smtp-Source: ABdhPJxSO06poktvSg+/b9fbylaq9+Oukb3dAY2aMMfEwLvI8yfmtVGQz9x8VYfw5K5KXuPTX6G5SQ== X-Received: by 2002:a9f:30c8:: with SMTP id k8mr1437772uab.130.1592551499716; Fri, 19 Jun 2020 00:24:59 -0700 (PDT) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com. [209.85.217.51]) by smtp.gmail.com with ESMTPSA id u199sm660936vku.42.2020.06.19.00.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 00:24:59 -0700 (PDT) Received: by mail-vs1-f51.google.com with SMTP id g129so5072942vsc.4; Fri, 19 Jun 2020 00:24:59 -0700 (PDT) X-Received: by 2002:a05:6102:2254:: with SMTP id e20mr6330944vsb.142.1592551498983; Fri, 19 Jun 2020 00:24:58 -0700 (PDT) MIME-Version: 1.0 References: <202006180657.05I6viix040418@repo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Fri, 19 Jun 2020 10:24:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r539531 - in head/security: . vigenere To: Adam Weinberger Cc: ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 49p9LP1p7Tz3RNs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of fernandoapesteguia@gmail.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=fernandoapesteguia@gmail.com X-Spamd-Result: default: False [-1.79 / 15.00]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-0.94)[-0.942]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[]; NEURAL_SPAM_SHORT(0.07)[0.073]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.44:from]; NEURAL_HAM_MEDIUM(-0.93)[-0.926]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.222.44:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 07:25:02 -0000 On Fri, Jun 19, 2020 at 8:49 AM Adam Weinberger wrote: > > On Thu, Jun 18, 2020 at 12:57 AM Fernando Apestegu=C3=ADa > wrote: > > > > Author: fernape > > Date: Thu Jun 18 06:57:44 2020 > > New Revision: 539531 > > URL: https://svnweb.freebsd.org/changeset/ports/539531 > > > > Log: > > new port: security/vigenere: cipher algorithm tool > > > > vigenere is an implementation of the Vigenere cipher algorithm extend= ed > > to the entire set of printable ASCII characters > > > > https://www.olivermahmoudi.com/programming/vigenere-cipher/ > > > > PR: 247244 > > Submitted by: fbsd@olivermahmoudi.com > > > > Added: > > head/security/vigenere/ > > head/security/vigenere/Makefile (contents, props changed) > > head/security/vigenere/distinfo (contents, props changed) > > head/security/vigenere/pkg-descr (contents, props changed) > > Modified: > > head/security/Makefile > > > > Modified: head/security/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/security/Makefile Thu Jun 18 06:57:40 2020 (r53953= 0) > > +++ head/security/Makefile Thu Jun 18 06:57:44 2020 (r53953= 1) > > @@ -1259,6 +1259,7 @@ > > SUBDIR +=3D vanguards-tor > > SUBDIR +=3D vault > > SUBDIR +=3D veracrypt > > + SUBDIR +=3D vigenere > > SUBDIR +=3D vinetto > > SUBDIR +=3D vlock > > SUBDIR +=3D vm-to-tor > > > > Added: head/security/vigenere/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/security/vigenere/Makefile Thu Jun 18 06:57:44 2020 = (r539531) > > @@ -0,0 +1,24 @@ > > +# $FreeBSD$ > > + > > +PORTNAME=3D vigenere > > +PORTVERSION=3D 1.0 > > +CATEGORIES=3D security > > +MASTER_SITES=3D http://www.olivermahmoudi.com/files/ > > + > > +MAINTAINER=3D fbsd@olivermahmoudi.com > > +COMMENT=3D Vigenere cipher cryptography tool > > + > > +LICENSE=3D BSD2CLAUSE > > +LICENSE_FILE=3D ${WRKSRC}/LICENSE > > + > > +PLIST_FILES=3D bin/vigenere \ > > + man/man1/vigenere.1.gz > > + > > +do-build: > > + cd ${WRKSRC} && ${CC} ${CFLAGS} ${LDFLAGS} -o ${PORTNAME} ${POR= TNAME}.c > > + > > +do-install: > > + ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/b= in > > + ${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/man= /man1 > > + > > +.include > > > > Added: head/security/vigenere/distinfo > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/security/vigenere/distinfo Thu Jun 18 06:57:44 2020 = (r539531) > > @@ -0,0 +1,3 @@ > > +TIMESTAMP =3D 1592095290 > > +SHA256 (vigenere-1.0.tar.gz) =3D 96bc7dc9b582a36ec020cee47f9840065b7be= b53ef8d5b68962643077b6c0b6b > > +SIZE (vigenere-1.0.tar.gz) =3D 5618 > > > > Added: head/security/vigenere/pkg-descr > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/security/vigenere/pkg-descr Thu Jun 18 06:57:44 2020 = (r539531) > > @@ -0,0 +1,6 @@ > > +vigenere is an implementation of the Vigenere cipher encryption > > +algorithm with an extension to all printable ASCII characters. > > +The utility is capable of encrypting/decrypting arguments that > > +are passed to it upon invocation or process input- and outputfiles. > > + > > +WWW: https://www.olivermahmoudi.com/programming/vigenere-cipher/ > > Hi Fernando, > > That WWW is 404, and there's no mention of the software on Oliver's websi= te. Hi Adam! I'm pretty sure I checked that, but maybe I missed it?. I will open a PR asking him about it. > > Is this cipher actively used for modern practical purposes? If not, > this sounds like a programming exercise and I'm not sure why it'd need > a port. Before including the new port I checked Oliver was the maintainer of other ports, some of which I had incidentally committed to recently (sysutils/mapdir). Some of his ports include security/caesarcipher that I assume nobody uses for modern practical purposes either :-) It also happens he is the original writer of the four ports he maintains. I read the Committers Guide about new ports (https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/arti= cle.html#ports-qa-adding) in search of policy but couldn't find any. Should submitters "make a case" for the new port to be included? Should the committer refuse if he/she evaluates the software is not useful enough? Cheers. > > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > https://www.adamw.org