From owner-cvs-src@FreeBSD.ORG Tue Oct 16 20:11:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A02216A419; Tue, 16 Oct 2007 20:11:16 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id DF89813C480; Tue, 16 Oct 2007 20:11:15 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 11924669211; Tue, 16 Oct 2007 22:11:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EoXjcV5w+zPY; Tue, 16 Oct 2007 22:11:13 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 1B1F366920F; Tue, 16 Oct 2007 22:11:13 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l9GKBCNG052816; Tue, 16 Oct 2007 22:11:12 +0200 (CEST) (envelope-from rdivacky) Date: Tue, 16 Oct 2007 22:11:12 +0200 From: Roman Divacky To: Scott Long Message-ID: <20071016201112.GA52731@freebsd.org> References: <200710122211.l9CMBM4J010733@repoman.freebsd.org> <20071016085414.GA27376@freebsd.org> <471517C8.9040505@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <471517C8.9040505@samsco.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 20:11:16 -0000 On Tue, Oct 16, 2007 at 01:58:00PM -0600, Scott Long wrote: > Roman Divacky wrote: > >On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote: > >>scottl 2007-10-12 22:11:22 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/cam/scsi scsi_all.h > >> Log: > >> Add a bunch of definitions and structures to support newer drivers. > > > >- page_start = (void *)((u_int8_t *)&mode_header[1] + > >+ page_start = (void *)((u_int8_t *)&mode_header[2] + > > scsi_2btoul(mode_header->blk_desc_len)); > > > >are you sure this belongs here? > > > > It's a minor bug fix that got grouped with the larger change. Are you > upset that it wasn't clearly documented in the commit message, or are > you pointing out that it's incorrect, or what? It was not documented in the commit message so I thought you might have commited something by mistake...